Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GR_LYCHEE,RZ_A1H,VK_RZ_A1H: Fix greentea ticker test case failures #10213

Merged
merged 4 commits into from Mar 27, 2019

Conversation

Projects
None yet
6 participants
@d-kato
Copy link
Contributor

commented Mar 25, 2019

Description

Fix for issue #10119
Fixed the greentea test failur of mbed-os-tests-mbed_platform-wait_ns.

+-------------------+---------------+--------------------------------------------+--------+--------------------+-------------+
| target            | platform_name | test suite                                 | result | elapsed_time (sec) | copy_method |
+-------------------+---------------+--------------------------------------------+--------+--------------------+-------------+
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | mbed-os-tests-mbed_drivers-ticker          | OK     | 44.42              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | mbed-os-tests-mbed_drivers-timeout         | OK     | 58.35              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | mbed-os-tests-mbed_hal-common_tickers_freq | OK     | 37.13              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | mbed-os-tests-mbed_platform-wait_ns        | OK     | 16.27              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | mbed-os-tests-mbedmicro-rtos-mbed-basic    | OK     | 26.42              | default     |
+-------------------+---------------+--------------------------------------------+--------+--------------------+-------------+

+----------------+---------------+--------------------------------------------+--------+--------------------+-------------+
| target         | platform_name | test suite                                 | result | elapsed_time (sec) | copy_method |
+----------------+---------------+--------------------------------------------+--------+--------------------+-------------+
| RZ_A1H-GCC_ARM | RZ_A1H        | mbed-os-tests-mbed_drivers-ticker          | OK     | 45.21              | default     |
| RZ_A1H-GCC_ARM | RZ_A1H        | mbed-os-tests-mbed_drivers-timeout         | OK     | 57.98              | default     |
| RZ_A1H-GCC_ARM | RZ_A1H        | mbed-os-tests-mbed_hal-common_tickers_freq | OK     | 38.49              | default     |
| RZ_A1H-GCC_ARM | RZ_A1H        | mbed-os-tests-mbed_platform-wait_ns        | OK     | 16.96              | default     |
| RZ_A1H-GCC_ARM | RZ_A1H        | mbed-os-tests-mbedmicro-rtos-mbed-basic    | OK     | 27.02              | default     |
+----------------+---------------+--------------------------------------------+--------+--------------------+-------------+

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@VeijoPesonen

Release Notes

@ciarmcom ciarmcom requested review from toyowata, VeijoPesonen and ARMmbed/mbed-os-maintainers Mar 25, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

@VeijoPesonen
Copy link
Contributor

left a comment

@d-kato bbfee59 looks good to me

mbedgt: test suite report:
| target            | platform_name | test suite                         | result | elapsed_time (sec) | copy_method |
|-------------------|---------------|------------------------------------|--------|--------------------|-------------|
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | tests-mbed_drivers-ticker          | OK     | 83.67              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | tests-mbed_drivers-timeout         | OK     | 96.42              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | tests-mbed_hal-common_tickers_freq | OK     | 75.23              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | tests-mbed_platform-wait_ns        | OK     | 34.11              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | tests-mbedmicro-rtos-mbed-basic    | OK     | 53.42              | default     |
mbedgt: test suite results: 5 OK
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Waiting on #10221 for astyle fix.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Hmm... The astyle fix is missing this fix: #10222

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

please re-base when you have time, it should resolve the astyle issue

d-kato added some commits Mar 25, 2019

Fix the value of SystemCoreClock
The OS timer of RZ/A1 uses P0 clock, so until now it has been set the value of P0 clock in SystemCoreClock.
Changed the system clock value to set to SystemCoreClock.
Changed to refer to P0 clock macro instead of SystemCoreClock in OS timer processing.
Removed clock mode decision of "SystemCoreClockUpdate()"
Since GPIO.PPR0 can not check clock mode, I changed it to set a fixed value for each board.

@d-kato d-kato force-pushed the d-kato:rza1xx_wait_ns branch from bbfee59 to 090fcb0 Mar 26, 2019

@d-kato

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

@NirSonnenschein, All right. I rebased.

@cmonr

cmonr approved these changes Mar 26, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Mar 26, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

CI started

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10213 from d-kato/rza1xx_wait_ns
GR_LYCHEE,RZ_A1H,VK_RZ_A1H: Fix greentea ticker test case failures
@mbed-ci

This comment has been minimized.

Copy link

commented Mar 26, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 26, 2019

@cmonr cmonr merged commit 54e1ec6 into ARMmbed:master Mar 27, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9096 cycles (-30 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.