Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GR_LYCHEE,RZ_A1H,VK_RZ_A1H: Fix greentea ticker test case failures #10213

Merged
merged 4 commits into from
Mar 27, 2019

Conversation

d-kato
Copy link
Contributor

@d-kato d-kato commented Mar 25, 2019

Description

Fix for issue #10119
Fixed the greentea test failur of mbed-os-tests-mbed_platform-wait_ns.

+-------------------+---------------+--------------------------------------------+--------+--------------------+-------------+
| target            | platform_name | test suite                                 | result | elapsed_time (sec) | copy_method |
+-------------------+---------------+--------------------------------------------+--------+--------------------+-------------+
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | mbed-os-tests-mbed_drivers-ticker          | OK     | 44.42              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | mbed-os-tests-mbed_drivers-timeout         | OK     | 58.35              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | mbed-os-tests-mbed_hal-common_tickers_freq | OK     | 37.13              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | mbed-os-tests-mbed_platform-wait_ns        | OK     | 16.27              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | mbed-os-tests-mbedmicro-rtos-mbed-basic    | OK     | 26.42              | default     |
+-------------------+---------------+--------------------------------------------+--------+--------------------+-------------+

+----------------+---------------+--------------------------------------------+--------+--------------------+-------------+
| target         | platform_name | test suite                                 | result | elapsed_time (sec) | copy_method |
+----------------+---------------+--------------------------------------------+--------+--------------------+-------------+
| RZ_A1H-GCC_ARM | RZ_A1H        | mbed-os-tests-mbed_drivers-ticker          | OK     | 45.21              | default     |
| RZ_A1H-GCC_ARM | RZ_A1H        | mbed-os-tests-mbed_drivers-timeout         | OK     | 57.98              | default     |
| RZ_A1H-GCC_ARM | RZ_A1H        | mbed-os-tests-mbed_hal-common_tickers_freq | OK     | 38.49              | default     |
| RZ_A1H-GCC_ARM | RZ_A1H        | mbed-os-tests-mbed_platform-wait_ns        | OK     | 16.96              | default     |
| RZ_A1H-GCC_ARM | RZ_A1H        | mbed-os-tests-mbedmicro-rtos-mbed-basic    | OK     | 27.02              | default     |
+----------------+---------------+--------------------------------------------+--------+--------------------+-------------+

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@VeijoPesonen

Release Notes

@ciarmcom ciarmcom requested review from toyowata, VeijoPesonen and a team March 25, 2019 12:00
@ciarmcom
Copy link
Member

@d-kato, thank you for your changes.
@VeijoPesonen @toyowata @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@VeijoPesonen VeijoPesonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-kato bbfee59 looks good to me

mbedgt: test suite report:
| target            | platform_name | test suite                         | result | elapsed_time (sec) | copy_method |
|-------------------|---------------|------------------------------------|--------|--------------------|-------------|
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | tests-mbed_drivers-ticker          | OK     | 83.67              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | tests-mbed_drivers-timeout         | OK     | 96.42              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | tests-mbed_hal-common_tickers_freq | OK     | 75.23              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | tests-mbed_platform-wait_ns        | OK     | 34.11              | default     |
| GR_LYCHEE-GCC_ARM | GR_LYCHEE     | tests-mbedmicro-rtos-mbed-basic    | OK     | 53.42              | default     |
mbedgt: test suite results: 5 OK

@cmonr
Copy link
Contributor

cmonr commented Mar 25, 2019

Waiting on #10221 for astyle fix.

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

Hmm... The astyle fix is missing this fix: #10222

@NirSonnenschein
Copy link
Contributor

please re-base when you have time, it should resolve the astyle issue

The OS timer of RZ/A1 uses P0 clock, so until now it has been set the value of P0 clock in SystemCoreClock.
Changed the system clock value to set to SystemCoreClock.
Changed to refer to P0 clock macro instead of SystemCoreClock in OS timer processing.
Since GPIO.PPR0 can not check clock mode, I changed it to set a fixed value for each board.
@d-kato
Copy link
Contributor Author

d-kato commented Mar 26, 2019

@NirSonnenschein, All right. I rebased.

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

CI started

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019
GR_LYCHEE,RZ_A1H,VK_RZ_A1H: Fix greentea ticker test case failures
@mbed-ci
Copy link

mbed-ci commented Mar 26, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants