Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for QSPI to Cypress Boards #10435

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
10 participants
@morser499
Copy link

commented Apr 17, 2019

Description

Added support for QSPI to Cypress targets

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Apr 17, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

@0xc0170
Copy link
Member

left a comment

Otherwise looks fine to me




// #define FAST_MODE_ENABLE() \

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Apr 17, 2019

Member

why this code is commented out?

This comment has been minimized.

Copy link
@morser499

morser499 Apr 26, 2019

Author

removed the commented code. this is not supported by the PSoC 6 device

This comment has been minimized.

Copy link
@offirko

offirko Apr 29, 2019

Contributor

Was the test "features-storage-tests-blockdevice-general_block_device" successful?

@@ -0,0 +1,259 @@
/* mbed Microcontroller Library
* Copyright (c) 2018-2018 ARM Limited
*

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Apr 17, 2019

Member

please add SPDX identifiers to new files

This comment has been minimized.

Copy link
@morser499
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Please also fix travis astyle

@maciejbocianski
Copy link
Member

left a comment

LGTM

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

We would like to produce 5.12.2 release candidate today prior holidays, please let us know when the update can be done.

},
"CY8CPROTO_062_4343W": {
"QSPI_FREQ": "50000000",
"QSPI_MIN_PROG_SIZE": "512"

This comment has been minimized.

Copy link
@offirko

offirko Apr 18, 2019

Contributor

Please note that SFDP standard requires minimum Program-Granularity of 1byte.
The standard and our code fully support 512 Bytes Page Size without the need for this parameter.
The parameter was added for supporting devices that couldn't support the standard, and has an impact on Filesystem heap.
If the flash chips that you're adding support SFDP standard and so does the Cypress target, then this parameter is not required.

This comment has been minimized.

Copy link
@morser499

morser499 Apr 26, 2019

Author

removed the prog_size setting as both the PSoC 6 and memory chip are compatible.

This comment has been minimized.

Copy link
@offirko

offirko Apr 29, 2019

Contributor

@morser499 - Thanks for the update! I'm not sure whether the test "features-storage-tests-blockdevice-general_block_device" runs as default - it would be a good test to verify the above.

This comment has been minimized.

Copy link
@morser499

morser499 Apr 29, 2019

Author

I did run those tests, however, I don't have most of the reports anymore. I can rerun them if you would like. Attached is a screenshot (it isn't letting me upload the html file) of the last log I ran.

062_ble_gcc

This comment has been minimized.

Copy link
@offirko

offirko Apr 29, 2019

Contributor

Most important is running "features-storage-tests-blockdevice-general_block_device" after you've removed the prog_size. And making sure in the test report that it ran on QSPIF blockdevice

This comment has been minimized.

Copy link
@morser499

morser499 Apr 29, 2019

Author

These tests were run after the removal of prog_size. How do I verify it ran on the QSPIF blockdevice?

This comment has been minimized.

Copy link
@morser499

morser499 Apr 29, 2019

Author

Just uploaded the details for the mbed-os-features-storage-tests-blockdevice-general_block_device (below) which seems to indicate that it was using QSPIF

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

This needs rebase, latest fixes were merged early today for 5.12.2. Please update

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 18, 2019

@0xc0170 0xc0170 removed the request for review from ARMmbed/mbed-os-test Apr 18, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

This needs rebase, latest fixes were merged early today for 5.12.2. Please update
@morser499 Any update on this please? This is blocking our 5.12.2 release...

@morser499 morser499 force-pushed the morser499:pr/cy-smif branch 3 times, most recently from 937c4bd to bf5ec6a Apr 26, 2019

@morser499

This comment has been minimized.

Copy link
Author

commented Apr 28, 2019

Please also fix travis astyle

Fixed

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 29, 2019

@0xc0170 0xc0170 changed the title Added support for QSPI to Cypress Boards Add support for QSPI to Cypress Boards Apr 29, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@offirko could you please re-review the changes ? Thanks

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Please review build failures, related to the changes

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Apr 30, 2019

@morser499

This comment has been minimized.

Copy link
Author

commented Apr 30, 2019

I can't access the failed build logs. Are they on a private server? Can someone attach them here so I can review and address the failures?

@0xc0170

This comment has been minimized.

@morser499 morser499 force-pushed the morser499:pr/cy-smif branch from bf5ec6a to 89ad9e2 Apr 30, 2019

@morser499

This comment has been minimized.

Copy link
Author

commented Apr 30, 2019

I believe all the test issues are now addressed

@adbridge adbridge added needs: CI and removed needs: work labels May 1, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@offirko could you please review the test fixes ? In the meantime, kicking off the ci.

@adbridge adbridge added needs: review and removed needs: CI labels May 1, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 1, 2019

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@morser499 morser499 force-pushed the morser499:pr/cy-smif branch from 89ad9e2 to a8570ff May 1, 2019

@morser499

This comment has been minimized.

Copy link
Author

commented May 1, 2019

I overlooked the Sequana CM0 target. That has now been fixed too.

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 2, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented May 2, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Exporters restarted (one failure that was success but failed as well)

Update: not yet rerun, having issue with CI

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 2, 2019

@ARMmbed/mbed-os-test review ^^ exporters rerun

@alekla01

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

Restarted the failed exporter (uvision6) / target (K66F) combinations.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 2, 2019

@0xc0170 0xc0170 merged commit 40f8cb9 into ARMmbed:master May 2, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8592 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@0xc0170 0xc0170 removed the ready for merge label May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.