Add support for QSPI to Cypress Boards #10435

morser499 · 2019-04-17T18:31:26Z

Description

Added support for QSPI to Cypress targets

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

morser499 · 2019-04-17T18:33:11Z

CY8CKIT_062_BLE_IAR.txt
CY8CKIT_062_WIFI_BT_IAR.txt
CY8CPROTO_062_4343W_IAR.txt
CY8CKIT_062_BLE_ARM.txt
CY8CKIT_062_WIFI_BT_ARM.txt
CY8CPROTO_062_4343W_ARM.txt
CY8CKIT_062_BLE_GCC.txt
CY8CKIT_062_WIFI_BT_GCC.txt
CY8CPROTO_062_4343W_GCC.txt

ciarmcom · 2019-04-17T19:00:32Z

@morser499, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-storage please review.

0xc0170

Otherwise looks fine to me

0xc0170 · 2019-04-17T19:26:16Z

TESTS/mbed_hal/qspi/flash_configs/S25FL512S_config.h

+
+
+
+// #define FAST_MODE_ENABLE()                                                  \


why this code is commented out?

removed the commented code. this is not supported by the PSoC 6 device

Was the test "features-storage-tests-blockdevice-general_block_device" successful?

0xc0170 · 2019-04-17T19:26:29Z

TESTS/mbed_hal/qspi/flash_configs/S25FL512S_config.h

@@ -0,0 +1,259 @@
+/* mbed Microcontroller Library
+ * Copyright (c) 2018-2018 ARM Limited
+ *


please add SPDX identifiers to new files

0xc0170 · 2019-04-18T05:23:21Z

Please also fix travis astyle

maciejbocianski

LGTM

0xc0170 · 2019-04-18T07:09:22Z

We would like to produce 5.12.2 release candidate today prior holidays, please let us know when the update can be done.

offirko · 2019-04-18T07:35:31Z

components/storage/blockdevice/COMPONENT_QSPIF/mbed_lib.json

+        }, 
+        "CY8CPROTO_062_4343W": {
+            "QSPI_FREQ": "50000000",
+            "QSPI_MIN_PROG_SIZE": "512"


Please note that SFDP standard requires minimum Program-Granularity of 1byte.
The standard and our code fully support 512 Bytes Page Size without the need for this parameter.
The parameter was added for supporting devices that couldn't support the standard, and has an impact on Filesystem heap.
If the flash chips that you're adding support SFDP standard and so does the Cypress target, then this parameter is not required.

removed the prog_size setting as both the PSoC 6 and memory chip are compatible.

@morser499 - Thanks for the update! I'm not sure whether the test "features-storage-tests-blockdevice-general_block_device" runs as default - it would be a good test to verify the above.

I did run those tests, however, I don't have most of the reports anymore. I can rerun them if you would like. Attached is a screenshot (it isn't letting me upload the html file) of the last log I ran.

Most important is running "features-storage-tests-blockdevice-general_block_device" after you've removed the prog_size. And making sure in the test report that it ran on QSPIF blockdevice

These tests were run after the removal of prog_size. How do I verify it ran on the QSPIF blockdevice?

Just uploaded the details for the mbed-os-features-storage-tests-blockdevice-general_block_device (below) which seems to indicate that it was using QSPIF

0xc0170 · 2019-04-18T11:48:46Z

This needs rebase, latest fixes were merged early today for 5.12.2. Please update

adbridge · 2019-04-23T14:30:54Z

This needs rebase, latest fixes were merged early today for 5.12.2. Please update
@morser499 Any update on this please? This is blocking our 5.12.2 release...

morser499 · 2019-04-28T17:56:41Z

Please also fix travis astyle

Fixed

adbridge · 2019-04-29T10:30:16Z

@offirko could you please re-review the changes ? Thanks

morser499 · 2019-04-30T17:38:31Z

I believe all the test issues are now addressed

adbridge · 2019-05-01T12:16:05Z

@offirko could you please review the test fixes ? In the meantime, kicking off the ci.

adbridge · 2019-05-01T12:18:27Z

CI started

mbed-ci · 2019-05-01T13:26:08Z

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

morser499 · 2019-05-01T15:26:05Z

I overlooked the Sequana CM0 target. That has now been fixed too.

0xc0170 · 2019-05-02T08:43:09Z

CI restarted

mbed-ci · 2019-05-02T10:47:54Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

0xc0170 · 2019-05-02T11:03:25Z

Exporters restarted (one failure that was success but failed as well)

Update: not yet rerun, having issue with CI

0xc0170 · 2019-05-02T11:24:09Z

@ARMmbed/mbed-os-test review ^^ exporters rerun

alekla01 · 2019-05-02T11:45:56Z

Restarted the failed exporter (uvision6) / target (K66F) combinations.

0xc0170 · 2019-06-04T08:38:47Z

This PR affects other boards. Looking at the commit, as it is squashed it is very hard to find a reason why TESTS/mbed_hal/qspi/qspi_test_utils.cpp is being changed here. Future reference: never change common code with target code in one commit if not related, they are not in this PR.

@ARMmbed/mbed-os-maintainers we need to request changes for commits like this, blame on me here as well.

Not reverting the entire PR (one commit), I can revert only changes to the common test code. The main question is: why these changes are needed and how they affect targets?

Remove some buggy code introduced to hal_qspi_test by PR ARMmbed#10435 Added support for QSPI to Cypress Boards a8570ff

Remove some buggy code introduced to hal_qspi_test by PR #10435 Added support for QSPI to Cypress Boards a8570ff

ciarmcom requested review from a team April 17, 2019 19:00

ciarmcom added the needs: review label Apr 17, 2019

0xc0170 requested changes Apr 17, 2019

View reviewed changes

0xc0170 added the release-version: 5.12.2 label Apr 17, 2019

maciejbocianski approved these changes Apr 18, 2019

View reviewed changes

offirko reviewed Apr 18, 2019

View reviewed changes

0xc0170 mentioned this pull request Apr 18, 2019

Cypress PSOC6 Targets missing QSPI Mbed HAL implementation #9897

Closed

0xc0170 added needs: work and removed needs: review labels Apr 18, 2019

0xc0170 removed the request for review from a team April 18, 2019 17:00

adbridge added release-version: 5.12.3 and removed release-version: 5.12.2 labels Apr 26, 2019

morser499 force-pushed the pr/cy-smif branch 3 times, most recently from 937c4bd to bf5ec6a Compare April 28, 2019 16:13

0xc0170 approved these changes Apr 29, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Apr 29, 2019

0xc0170 changed the title ~~Added support for QSPI to Cypress Boards~~ Add support for QSPI to Cypress Boards Apr 29, 2019

adbridge added needs: CI and removed needs: work labels May 1, 2019

adbridge added needs: review and removed needs: CI labels May 1, 2019

Added support for QSPI to Cypress Boards

a8570ff

morser499 force-pushed the pr/cy-smif branch from 89ad9e2 to a8570ff Compare May 1, 2019 14:10

maclobdell added the devices: cypress label May 1, 2019

0xc0170 added needs: CI and removed needs: review labels May 2, 2019

0xc0170 added ready for merge and removed needs: CI labels May 2, 2019

0xc0170 merged commit 40f8cb9 into ARMmbed:master May 2, 2019

0xc0170 removed the ready for merge label May 2, 2019

jeromecoutant mentioned this pull request Jun 4, 2019

DISCO_L475VG_IOT01A: qspi failing in nightly #10730

Closed

maciejbocianski mentioned this pull request Jun 4, 2019

K82F: qspi test failing in nightly #10728

Closed

maciejbocianski added a commit to maciejbocianski/mbed-os that referenced this pull request Jun 4, 2019

hal_qspi_test: undo buggy code

90fbab0

Remove some buggy code introduced to hal_qspi_test by PR ARMmbed#10435 Added support for QSPI to Cypress Boards a8570ff

maciejbocianski mentioned this pull request Jun 4, 2019

hal_qspi_test: undo buggy code #10755

Merged

artokin pushed a commit that referenced this pull request Jul 3, 2019

hal_qspi_test: undo buggy code

b3ace3d

Remove some buggy code introduced to hal_qspi_test by PR #10435 Added support for QSPI to Cypress Boards a8570ff

evedon pushed a commit that referenced this pull request Jul 11, 2019

hal_qspi_test: undo buggy code

d9e2930

Remove some buggy code introduced to hal_qspi_test by PR #10435 Added support for QSPI to Cypress Boards a8570ff

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for QSPI to Cypress Boards #10435

Add support for QSPI to Cypress Boards #10435

morser499 commented Apr 17, 2019

morser499 commented Apr 17, 2019

ciarmcom commented Apr 17, 2019

0xc0170 left a comment

0xc0170 Apr 17, 2019

morser499 Apr 26, 2019

offirko Apr 29, 2019

0xc0170 Apr 17, 2019

morser499 Apr 26, 2019

0xc0170 commented Apr 18, 2019

maciejbocianski left a comment

0xc0170 commented Apr 18, 2019

offirko Apr 18, 2019 •

edited

morser499 Apr 26, 2019

offirko Apr 29, 2019

morser499 Apr 29, 2019

offirko Apr 29, 2019

morser499 Apr 29, 2019

morser499 Apr 29, 2019

0xc0170 commented Apr 18, 2019

adbridge commented Apr 23, 2019

morser499 commented Apr 28, 2019

adbridge commented Apr 29, 2019

morser499 commented Apr 30, 2019 •

edited

adbridge commented May 1, 2019 •

edited

adbridge commented May 1, 2019

mbed-ci commented May 1, 2019

morser499 commented May 1, 2019

0xc0170 commented May 2, 2019

mbed-ci commented May 2, 2019

0xc0170 commented May 2, 2019 •

edited

0xc0170 commented May 2, 2019

alekla01 commented May 2, 2019

0xc0170 commented Jun 4, 2019 •

edited

Add support for QSPI to Cypress Boards #10435

Add support for QSPI to Cypress Boards #10435

Conversation

morser499 commented Apr 17, 2019

Description

Pull request type

morser499 commented Apr 17, 2019

ciarmcom commented Apr 17, 2019

0xc0170 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xc0170 commented Apr 18, 2019

maciejbocianski left a comment

Choose a reason for hiding this comment

0xc0170 commented Apr 18, 2019

offirko Apr 18, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xc0170 commented Apr 18, 2019

adbridge commented Apr 23, 2019

morser499 commented Apr 28, 2019

adbridge commented Apr 29, 2019

morser499 commented Apr 30, 2019 • edited

adbridge commented May 1, 2019 • edited

adbridge commented May 1, 2019

mbed-ci commented May 1, 2019

morser499 commented May 1, 2019

0xc0170 commented May 2, 2019

mbed-ci commented May 2, 2019

0xc0170 commented May 2, 2019 • edited

0xc0170 commented May 2, 2019

alekla01 commented May 2, 2019

0xc0170 commented Jun 4, 2019 • edited

offirko Apr 18, 2019 •

edited

morser499 commented Apr 30, 2019 •

edited

adbridge commented May 1, 2019 •

edited

0xc0170 commented May 2, 2019 •

edited

0xc0170 commented Jun 4, 2019 •

edited