Update ticker to map closely to hardware #5028

c1728p9 · 2017-09-05T16:57:09Z

Allow tickers to specify their native frequency and number of bits. This allows the conversion to happen in common code rather than in each vendor's implementation.

c1728p9 · 2017-09-14T01:17:35Z

/morph test

mbed-bot · 2017-09-14T03:49:17Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1303

Test failed!

c1728p9 · 2017-09-19T21:44:56Z

/morph test-nightly

mbed-bot · 2017-09-20T03:35:27Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1341

Test failed!

0xc0170 · 2017-09-20T07:59:39Z

Please look at failures, tickers mostly

Allow tickers to specify their native frequency and number of bits. This allows the conversion to happen in common code rather than in each vendor's implementation.

👍 for the info structure addition, still pending reviews

pan-

Quite happy with that change, it really remove all the conversion and overflow bookkeeping from target code.

I would ask for another review to ensure nothing has been missed.

pan- · 2017-09-20T14:19:30Z

hal/mbed_ticker_api.c

+    uint32_t frequency = info->frequency;
+    if (info->frequency == 0) {
+        MBED_ASSERT(0);
+        frequency = 1;


I'll update this to default to 1MHz rather than 1Hz.

pan- · 2017-09-20T14:23:37Z

hal/mbed_ticker_api.c

+        MBED_ASSERT(0);
+        bits = 32;
+    }
+    uint32_t max_delta = 0x7 << (bits - 4); // 7/16th


If bits is less than 3 this operation is undefined. Might be worthy to constraint bits in the range [32:4].

pan- · 2017-09-20T14:52:54Z

hal/mbed_ticker_api.c

+        return;
+    }
+
+    uint64_t new_ticks = (ticker_time - queue->tick_last_read) & queue->bitmask;


I'd use the wording elapsed_ticks and elapsed_us which seems to me more precise but I might be completely wrong here 😄 .

sound good. I updated the variables

c1728p9 · 2017-09-20T16:56:56Z

PR #5096 is needed before testing will pass on this PR. This is because us_ticker_read() and lp_ticker_read() no longer returns the same value as ticker_read(ticker). The call to ticker_read(ticker) both scales the frequency and starts counting from 0.

c1728p9 · 2017-09-20T18:32:16Z

Addressed @pan-'s comments and rebased to master

0xc0170

Should we add here now that deep sleep locking info?

0xc0170 · 2017-09-21T07:31:22Z

hal/ticker_api.h

+    uint64_t max_delta_us;              /**< Largest delta in us that can be used when scheduling */
+    uint32_t tick_last_read;            /**< Last tick read */
+    uint64_t tick_remainder;            /**< Ticks that have not been added to base_time */
+    us_timestamp_t base_time;


why are we missing docs for base time? I dont see base_time used anywhere in this patch.

what are units for max delta (might not be that clear diff vs max_delta_us for someone?).

This wasn't actually being used so I removed it. I also updated the comments next to max_delta to indicate that the delta was in ticks.

c1728p9 · 2017-09-21T15:51:48Z

Should we add here now that deep sleep locking info?

This PR is big enough as it is, it might be best as a separate PR on top of this. What do you think @0xc0170 and @pan-?

pan- · 2017-09-21T16:09:34Z

separate PR.

jiandeng · 2017-09-26T13:51:14Z

hal/mbed_ticker_api.c

+    if (match_tick > prev_tick) {
+        return (cur_tick >= match_tick) || (cur_tick < prev_tick);
+    } else {
+        return (cur_tick < match_tick) && (cur_tick >= prev_tick);


If match_tick <= prev_tick, how could prev_tick <= cur_tick < match_tick?

Good catch! This is a bug.

c1728p9 · 2017-09-27T21:47:13Z

Rebased to master and fixed ticker mismatch calculation. Diff for the new changes can be found in 6712718

mbed-bot · 2017-09-30T08:34:06Z

/morph test-nightly

mbed-bot · 2017-09-30T18:50:01Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1458

Test failed!

mbed-bot · 2017-10-01T03:04:00Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1458

Test failed!

Output

mbed Build Number: 1463

Test failed!

mbed-bot · 2017-10-01T11:58:31Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1458

Test failed!

Output

mbed Build Number: 1463

Test failed!

Output

mbed Build Number: 1469

Test failed!

mbed-bot · 2017-10-01T21:20:11Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1458

Test failed!

Output

mbed Build Number: 1463

Test failed!

Output

mbed Build Number: 1469

Test failed!

Output

mbed Build Number: 1474

Test failed!

mbed-bot · 2017-10-02T06:29:31Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly
Output

mbed Build Number: 1458

Test failed!

Output

mbed Build Number: 1463

Test failed!

Output

mbed Build Number: 1469

Test failed!

Output

mbed Build Number: 1474

Test failed!

Output

mbed Build Number: 1479

Test failed!

0xc0170 · 2017-10-02T11:39:31Z

Besides couple of nightly runs, I reviewed few, ticker or lp_timeout fail, please review the latest test results

c1728p9 · 2017-10-03T00:51:38Z

This PR won't pass testing without #5242

theotherjimmy · 2017-10-05T16:09:33Z

@c1728p9 It looks like this needs a rebase.

Allow tickers to specify their native frequency and number of bits. This allows the conversion to happen in common code rather than in each vendor's implementation.

Add optimizations for the most common use cases of the us ticker, 1MHz, and the lp ticker, 32KHz.

Add weak implementations of *_ticker_get_info which returns 1MHz and a width of 32 bits. This allows the updated Ticker API to work with existing devices. Note - in the future when all targets have implemented *_ticker_get_info these weak functions will be removed.

Increase the hal ticker test time from 30s to 60s to prevent a timeout from occurring on slower devices, such as the nrf51.

c1728p9 · 2017-10-05T17:09:07Z

rebased onto master

0xc0170 · 2017-10-06T12:30:09Z

cc @bulislaw @scartmell-arm

0xc0170 · 2017-10-09T11:15:10Z

/morph test-nightly

theotherjimmy · 2017-10-09T16:04:50Z

retest uvisor

mbed-bot · 2017-10-10T00:44:43Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1553

All builds and test passed!

0xc0170 · 2017-10-10T09:14:01Z

It is now ready for integration.

@c1728p9 This is backward compatible, thus not required to be minor, is that correct?

c1728p9 · 2017-10-10T14:41:20Z

Hi @0xc0170, yes this is backwards compatible.

theotherjimmy · 2017-10-10T22:53:44Z

@AnotherButler More new APIs here.

mbed-ci · 2017-10-11T03:19:53Z

Build : ABORTED

Build number : 87
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5028/

AnotherButler · 2017-10-12T15:22:50Z

@theotherjimmy Thanks. I've made a note of that and talked to @c1728p9 about docs. This should not affect this PR being merged.

c1728p9 added the needs: work label Sep 5, 2017

c1728p9 requested a review from pan- September 5, 2017 16:58

c1728p9 force-pushed the ticker_api_changes branch from 16258ad to f644020 Compare September 14, 2017 01:16

c1728p9 removed the needs: work label Sep 14, 2017

theotherjimmy added the needs: work label Sep 14, 2017

c1728p9 force-pushed the ticker_api_changes branch from f644020 to 31189f2 Compare September 19, 2017 21:03

c1728p9 changed the title ~~Add support for various ticker implementations~~ Update ticker to map closely to hardware Sep 19, 2017

pan- mentioned this pull request Sep 20, 2017

Enable deepsleep for LowPowerXXX objects #5148

Merged

pan- reviewed Sep 20, 2017

View reviewed changes

c1728p9 force-pushed the ticker_api_changes branch from 31189f2 to 37fcaf8 Compare September 20, 2017 18:31

0xc0170 reviewed Sep 21, 2017

View reviewed changes

c1728p9 force-pushed the ticker_api_changes branch 2 times, most recently from 8225481 to 3ecba30 Compare September 21, 2017 15:49

c1728p9 mentioned this pull request Sep 21, 2017

Ticker specification (branch feature-hal-spec-ticker) #5164

Merged

0xc0170 approved these changes Sep 22, 2017

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Sep 22, 2017

jiandeng reviewed Sep 26, 2017

View reviewed changes

c1728p9 force-pushed the ticker_api_changes branch from 3ecba30 to 6712718 Compare September 27, 2017 21:45

pan- approved these changes Sep 29, 2017

View reviewed changes

c1728p9 added 4 commits October 5, 2017 11:57

Update ticker to map closely to hardware

ec55b82

Allow tickers to specify their native frequency and number of bits. This allows the conversion to happen in common code rather than in each vendor's implementation.

Optimize 1MHz and 32KHz use cases

0d3714e

Add optimizations for the most common use cases of the us ticker, 1MHz, and the lp ticker, 32KHz.

Increase ticker test time for slower devices

77dd420

Increase the hal ticker test time from 30s to 60s to prevent a timeout from occurring on slower devices, such as the nrf51.

c1728p9 force-pushed the ticker_api_changes branch from 9f5b922 to 77dd420 Compare October 5, 2017 17:08

0xc0170 added ready for merge and removed needs: CI labels Oct 10, 2017

0xc0170 added the release-version: 5.7.0-rc1 label Oct 10, 2017

theotherjimmy merged commit fad6755 into ARMmbed:master Oct 13, 2017

theotherjimmy removed the ready for merge label Oct 13, 2017

adbridge mentioned this pull request Oct 20, 2017

Add fix for Timer test - provide missing get_info ticker interface fu… #5325

Merged

Update ticker to map closely to hardware #5028

Update ticker to map closely to hardware #5028

Conversation

c1728p9 commented Sep 5, 2017

c1728p9 commented Sep 14, 2017

mbed-bot commented Sep 14, 2017

Output

c1728p9 commented Sep 19, 2017

mbed-bot commented Sep 20, 2017

Output

0xc0170 commented Sep 20, 2017

pan- left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

c1728p9 commented Sep 20, 2017

c1728p9 commented Sep 20, 2017

0xc0170 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

c1728p9 commented Sep 21, 2017

pan- commented Sep 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

c1728p9 commented Sep 27, 2017

mbed-bot commented Sep 30, 2017

mbed-bot commented Sep 30, 2017

Output

mbed-bot commented Oct 1, 2017

Output

Output

mbed-bot commented Oct 1, 2017

Output

Output

Output

mbed-bot commented Oct 1, 2017

Output

Output

Output

Output

mbed-bot commented Oct 2, 2017

Output

Output

Output

Output

Output

0xc0170 commented Oct 2, 2017

c1728p9 commented Oct 3, 2017

theotherjimmy commented Oct 5, 2017

c1728p9 commented Oct 5, 2017

0xc0170 commented Oct 6, 2017

0xc0170 commented Oct 9, 2017

theotherjimmy commented Oct 9, 2017

mbed-bot commented Oct 10, 2017

Output

0xc0170 commented Oct 10, 2017

c1728p9 commented Oct 10, 2017

theotherjimmy commented Oct 10, 2017

mbed-ci commented Oct 11, 2017

AnotherButler commented Oct 12, 2017