malloc test: fix out of memory problem for NUCLEO_F070RB #5338

maciejbocianski · 2017-10-18T10:23:28Z

Description

This test cause out of memory error ("Operator new[] out of memory") when run on NUCLEO_F070RB with GCC_ARM compiler

Changes was introduced to reduce heap allocations
Now test threads uses static memory as a stack memory

Status

READY

Migrations

NO

jeromecoutant · 2017-10-18T10:54:58Z

Hi
What do you think about #4890 ?

jeromecoutant · 2017-10-18T10:56:07Z

@c1728p9

0xc0170 · 2017-10-18T11:09:27Z

@jeromecoutant Thanks for the reference.
@maciejbocianski Have you reviewed the referenced PR ? I believe both of these patches fixing the same problem.

0xc0170 · 2017-10-18T11:20:15Z

This patch is also related #5285 (how much space should a target have available by default).

0xc0170 · 2017-10-18T11:20:42Z

cc @bulislaw @c1728p9

0xc0170 · 2017-10-19T09:59:55Z

@jeromecoutant I believe with this patch, both devices you encoutered problems earlier (NUCLEO_F070RB, NUCLEO_F072RB) should pass

0xc0170 · 2017-10-19T10:00:05Z

/morph build

maciejbocianski · 2017-10-19T10:11:52Z

tested only on NUCLEO_F070RB
but currently none of them are tested on CI

mbed-ci · 2017-10-19T10:55:38Z

Build : SUCCESS

Build number : 255
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5338/

Skipping test trigger, missing label 'NEED CI'

0xc0170 · 2017-10-19T15:25:35Z

@jeromecoutant I believe with this patch, both devices you encoutered problems earlier (NUCLEO_F070RB, NUCLEO_F072RB) should pass

Are you happy with this patch, please review

jeromecoutant · 2017-10-19T15:48:14Z

Hi

Yes, this makes the malloc test passed. Thx!

Maybe we can apply the same patch with other failed rtos tests ?

adbridge · 2017-10-24T11:19:47Z

@ @bulislaw @c1728p9 bump

bulislaw · 2017-10-24T14:08:22Z

@maciejbocianski are you able to do the same for other failing tests as suggested in the previous comment?

bulislaw · 2017-10-26T21:47:00Z

/morph build

mbed-ci · 2017-10-26T22:34:22Z

Build : SUCCESS

Build number : 353
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5338/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-10-27T08:53:25Z

Test : FAILURE

Build number : 164
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5338/164

maciejbocianski · 2017-10-27T12:47:48Z

problem fixed - there was lack of thread stack alignment

0xc0170 · 2017-10-27T15:13:25Z

/morph build

mbed-ci · 2017-10-27T15:52:12Z

Build : SUCCESS

Build number : 356
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5338/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-10-27T19:28:44Z

Test : SUCCESS

Build number : 169
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5338/169

jeromecoutant · 2017-10-30T11:00:53Z

Hi

Quick comment to add information:

| NUCLEO_F070RB-GCC_ARM | tests-mbedmicro-rtos-mbed-mail | TIMEOUT

=> #5376

| NUCLEO_F070RB-GCC_ARM | tests-mbedmicro-rtos-mbed-semaphore | TIMEOUT

=> #5377

| NUCLEO_F070RB-GCC_ARM | tests-mbedmicro-rtos-mbed-threads | TIMEOUT

=> #5360

Thx!

adbridge · 2017-10-30T12:30:31Z

15:59:20 [K64F] [1509119959.83][HTST][INF] {{result;sync_failed}}
15:59:20 [K64F] mbedgt: checking for GCOV data...
15:59:20 [K64F] mbedgt: mbed-host-test-runner: stopped and returned 'SYNC_FAILED'
15:59:20 [K64F] mbedgt: test on hardware with target id: DUMMY
15:59:20 [K64F] mbedgt: test suite 'autogen-tests-uvisor-k64f_gcc_arm_r_1_1_2' ....................................... SYNC_FAILED in 34.69 sec
15:59:20 [K64F] test case: 'box_id_namespace_ok' ............................................................. OK in 0.00 sec
15:59:20 [K64F] test case: 'box_id_namespace_swapped_out_buffer' ............................................. ERROR in 0.00 sec
15:59:20 [K64F] test case: 'box_id_namespace_unowned_buffer' ................................................. OK in 0.00 sec
15:59:20 [K64F] test case: 'ipc_test_1/.r./s.a/.../' ......................................................... FAIL in 0.00 sec

@orenc17a Any idea why this is failing ?

0xc0170 · 2017-11-02T08:20:22Z

/morph uvisor-test

c1728p9 · 2017-11-02T15:27:08Z

TESTS/mbedmicro-rtos-mbed/malloc/main.cpp

@@ -54,17 +54,22 @@ void task_using_malloc(void)

 int main()
 {
+    // static stack for threads to reduce heap usage on devices with small RAM
+    // and eliminate run out of heap memory problem
+    MBED_ALIGN(8) uint8_t stack[THREAD_STACK_SIZE * NUM_THREADS];


The alignment isn't necessary with #5405.

If you make this a two dimensional array then the loop below will be clearer.

Declaration:

uint8_t stack[NUM_THREADS][THREAD_STACK_SIZE];

Loop:

thread_list[i] = new Thread(osPriorityNormal, THREAD_STACK_SIZE, stack[i]);

theotherjimmy · 2017-11-02T15:39:59Z

@c1728p9 Are you requesting changes? We were about to merge this.

c1728p9 · 2017-11-02T15:42:06Z

I don't want to block anything so lets merge it. @maciejbocianski can you address the comments in a separate PR?

malloc test: fix out of memory problem for NUCLEO_F070RB

maciejbocianski · 2017-11-03T14:21:52Z

@c1728p9 sure, I will address it in separate PR (#5430)

mbed-ci · 2017-11-03T15:06:12Z

Build : SUCCESS

Build number : 422
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5338/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-11-03T15:54:09Z

Build : SUCCESS

Build number : 424
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5338/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-11-03T17:27:48Z

Test : FAILURE

Build number : 213
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5338/213

mbed-ci · 2017-11-03T17:29:38Z

Test : FAILURE

Build number : 214
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5338/214

maciejbocianski mentioned this pull request Oct 18, 2017

malloc test refactoring #5323

Merged

maciejbocianski force-pushed the malloc_fix branch from f7dae3e to 86860e7 Compare October 18, 2017 10:30

0xc0170 added the needs: review label Oct 18, 2017

maciejbocianski force-pushed the malloc_fix branch from 86860e7 to 173c314 Compare October 19, 2017 09:04

maciejbocianski mentioned this pull request Oct 19, 2017

mbedmicro-rtos-mbed tests : reduce memory consumption #4890

Closed

bulislaw approved these changes Oct 26, 2017

View reviewed changes

malloc test - reduce heap usage

6bda590

maciejbocianski force-pushed the malloc_fix branch from 173c314 to 6bda590 Compare October 27, 2017 12:32

0xc0170 added needs: CI and removed needs: review labels Oct 27, 2017

0xc0170 approved these changes Nov 2, 2017

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Nov 2, 2017

c1728p9 reviewed Nov 2, 2017

View reviewed changes

theotherjimmy added a commit that referenced this pull request Nov 2, 2017

Merge pull request #5338 from maciejbocianski/malloc_fix

d1c65c9

malloc test: fix out of memory problem for NUCLEO_F070RB

theotherjimmy merged commit d1c65c9 into ARMmbed:master Nov 2, 2017

theotherjimmy added release-version: 5.6.4 and removed ready for merge labels Nov 2, 2017

maciejbocianski added a commit to maciejbocianski/mbed-os that referenced this pull request Nov 3, 2017

small supplement for PR ARMmbed#5338

0151b1c

maciejbocianski mentioned this pull request Nov 3, 2017

malloc test: change stack array to two dimensional array #5430

Merged

adbridge pushed a commit that referenced this pull request Nov 17, 2017

small supplement for PR #5338

3aa46e6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

malloc test: fix out of memory problem for NUCLEO_F070RB #5338

malloc test: fix out of memory problem for NUCLEO_F070RB #5338

maciejbocianski commented Oct 18, 2017 •

edited

Loading

jeromecoutant commented Oct 18, 2017

jeromecoutant commented Oct 18, 2017

0xc0170 commented Oct 18, 2017

0xc0170 commented Oct 18, 2017

0xc0170 commented Oct 18, 2017

0xc0170 commented Oct 19, 2017

0xc0170 commented Oct 19, 2017

maciejbocianski commented Oct 19, 2017 •

edited

Loading

mbed-ci commented Oct 19, 2017

0xc0170 commented Oct 19, 2017

jeromecoutant commented Oct 19, 2017

adbridge commented Oct 24, 2017

bulislaw commented Oct 24, 2017

bulislaw commented Oct 26, 2017

mbed-ci commented Oct 26, 2017

mbed-ci commented Oct 27, 2017

maciejbocianski commented Oct 27, 2017

0xc0170 commented Oct 27, 2017

mbed-ci commented Oct 27, 2017

mbed-ci commented Oct 27, 2017

jeromecoutant commented Oct 30, 2017

adbridge commented Oct 30, 2017

0xc0170 commented Nov 2, 2017

c1728p9 Nov 2, 2017

theotherjimmy commented Nov 2, 2017

c1728p9 commented Nov 2, 2017

maciejbocianski commented Nov 3, 2017 •

edited

Loading

mbed-ci commented Nov 3, 2017

mbed-ci commented Nov 3, 2017

mbed-ci commented Nov 3, 2017

mbed-ci commented Nov 3, 2017

malloc test: fix out of memory problem for NUCLEO_F070RB #5338

malloc test: fix out of memory problem for NUCLEO_F070RB #5338

Conversation

maciejbocianski commented Oct 18, 2017 • edited Loading

Description

Status

Migrations

jeromecoutant commented Oct 18, 2017

jeromecoutant commented Oct 18, 2017

0xc0170 commented Oct 18, 2017

0xc0170 commented Oct 18, 2017

0xc0170 commented Oct 18, 2017

0xc0170 commented Oct 19, 2017

0xc0170 commented Oct 19, 2017

maciejbocianski commented Oct 19, 2017 • edited Loading

mbed-ci commented Oct 19, 2017

0xc0170 commented Oct 19, 2017

jeromecoutant commented Oct 19, 2017

adbridge commented Oct 24, 2017

bulislaw commented Oct 24, 2017

bulislaw commented Oct 26, 2017

mbed-ci commented Oct 26, 2017

Triggering tests

mbed-ci commented Oct 27, 2017

maciejbocianski commented Oct 27, 2017

0xc0170 commented Oct 27, 2017

mbed-ci commented Oct 27, 2017

Triggering tests

mbed-ci commented Oct 27, 2017

jeromecoutant commented Oct 30, 2017

adbridge commented Oct 30, 2017

0xc0170 commented Nov 2, 2017

Choose a reason for hiding this comment

theotherjimmy commented Nov 2, 2017

c1728p9 commented Nov 2, 2017

maciejbocianski commented Nov 3, 2017 • edited Loading

mbed-ci commented Nov 3, 2017

Triggering tests

mbed-ci commented Nov 3, 2017

Triggering tests

mbed-ci commented Nov 3, 2017

mbed-ci commented Nov 3, 2017

maciejbocianski commented Oct 18, 2017 •

edited

Loading

maciejbocianski commented Oct 19, 2017 •

edited

Loading

maciejbocianski commented Nov 3, 2017 •

edited

Loading