New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

threads test adjust to run on devices with small RAM #5360

Merged
merged 2 commits into from Nov 27, 2017

Conversation

Projects
None yet
6 participants
@maciejbocianski
Member

maciejbocianski commented Oct 23, 2017

Description

PR contains changes required to run test on NUCLEO_F070RB (16kB RAM) device
In the end we had to reduce thread number from 3 to 2 only in parallel thread tests which create child thread

After memory optimization for devices with 16kB RAM it was seen some problems with threads stack size on some boards (e.g NRF51_DK).
We decided to forfeit this test on devices with small RAM (e.g. NUCLEO_F070RB) and increase test threads stack size to make test working on other boards
See commit bc99556

Status

READY

Migrations

NO

Related PRs

#4890

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Oct 23, 2017

it's less-invasive version of #4890
please review @bulislaw @c1728p9 @0xc0170 @jeromecoutant

@bulislaw

This comment has been minimized.

Member

bulislaw commented Oct 26, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 26, 2017

Build : SUCCESS

Build number : 352
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5360/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 27, 2017

nrf-51dk failures related to this change, please review them

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Oct 30, 2017

Approved!

| NUCLEO_F070RB-GCC_ARM | NUCLEO_F070RB | tests-mbedmicro-rtos-mbed-threads | OK | 28.15 | default |
| NUCLEO_F072RB-GCC_ARM | NUCLEO_F072RB | tests-mbedmicro-rtos-mbed-threads | OK | 26.83 | default |

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Oct 31, 2017

needs further memory optimization or test reduction if #5386 will not yield any additional free heap memory - working on it

@0xc0170 0xc0170 added needs: work and removed needs: review labels Nov 2, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 16, 2017

@maciejbocianski Shall this be closed and opened once updated ?

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 16, 2017

Build : SUCCESS

Build number : 535
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5360/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@bulislaw

This comment has been minimized.

Member

bulislaw commented Nov 21, 2017

@maciejbocianski please fix the issues with nrf51

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 22, 2017

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Nov 22, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 22, 2017

Build : SUCCESS

Build number : 573
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5360/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Nov 22, 2017

@bulislaw @0xc0170 fix for NRF51_DK was added see PR description

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 24, 2017

@theotherjimmy @studavekar Can you investigate the latest failure above? I've seen it this week already, build is OK but later it fails during termination? and reports both success and failure. Attached below the log (only the last part of it):

Invoking: Cross ARM GNU Print Size
arm-none-eabi-size --format=berkeley "mbed-os-example-blinky.elf"
Invoking: Cross ARM GNU Create Flash Image
arm-none-eabi-objcopy -O binary "mbed-os-example-blinky.elf"  "mbed-os-example-blinky.bin"
   text	   data	    bss	    dec	    hex	filename
  58088	   2668	   6856	  67612	  1081c	mbed-os-example-blinky.elf
Finished building: mbed-os-example-blinky.bin
Finished building: mbed-os-example-blinky.siz
 
 

15:46:38 Build Finished (took 35s.116ms)


==========STDERR==========
Eclipse:
JVM terminated. Exit code=1
/usr/bin/java
-Dosgi.requiredJavaVersion=1.8
-XX:+UseG1GC
-XX:+UseStringDeduplication
-Dosgi.requiredJavaVersion=1.8
-Xms256m
-Xmx1024m
-jar /usr/local/eclipse//plugins/org.eclipse.equinox.launcher_1.3.201.v20161025-1711.jar
-os linux
-ws gtk
-arch x86_64
-launcher /usr/local/eclipse/eclipse
-name Eclipse
--launcher.library /usr/local/eclipse//plugins/org.eclipse.equinox.launcher.gtk.linux.x86_64_1.1.401.v20161122-1740/eclipse_1618.so
-startup /usr/local/eclipse//plugins/org.eclipse.equinox.launcher_1.3.201.v20161025-1711.jar
--launcher.appendVmargs
-exitdata 298009
-product org.eclipse.epp.package.cpp.product
-application org.eclipse.cdt.managedbuilder.core.headlessbuild
-data /tmp/tmp2mVpkL
-import /builds/ws/exporter-build-matrix/187/WIZWIKI_W7500P_gnuarmeclipse/sources/examples/mbed-os-example-blinky
-cleanBuild mbed-os-example-blinky
-vm /usr/bin/java
-vmargs
-Dosgi.requiredJavaVersion=1.8
-XX:+UseG1GC
-XX:+UseStringDeduplication
-Dosgi.requiredJavaVersion=1.8
-Xms256m
-Xmx1024m
-jar /usr/local/eclipse//plugins/org.eclipse.equinox.launcher_1.3.201.v20161025-1711.jar 

SUCCESS
FAILURE
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 24, 2017

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 removed the needs: CI label Nov 24, 2017

@bulislaw

This comment has been minimized.

Member

bulislaw commented Nov 27, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 27, 2017

@0xc0170 @theotherjimmy ping

Will be integrated during the sync today

@theotherjimmy theotherjimmy merged commit 70522bb into ARMmbed:master Nov 27, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Dec 8, 2017

Hi

Bad news with 5.6.6 version
Test is FAILED running case #11: 'Testing parallel threads with child'
[1512442049.35][CONN][RXD] Operator new out of memory

NUCLEO_F070RB-GCC_ARM | NUCLEO_F070RB | tests-mbedmicro-rtos-mbed-threads | Testing parallel threads with child | 0 | 0 | ERROR | 0.0 |
| NUCLEO_F072RB-GCC_ARM | NUCLEO_F072RB | tests-mbedmicro-rtos-mbed-threads | Testing parallel threads with child | 0 | 0 | ERROR | 0.0 |

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Dec 11, 2017

we have two ways out:

  • further test reduction (what will significantly reduce test scope)
  • solving GCC malloc issue (#5386)

@bulislaw @0xc0170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment