-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Realtek RTL8195AM A3 fix #5611
Realtek RTL8195AM A3 fix #5611
Conversation
@tung7970 - please review. |
@adbridge - I'd like to get this to next Mbed OS patch release, please. |
Based on the Mbed OS website the A3 is connected to "DAC", however there is no define for DAC. In order to get the Realtek RTL8195AM to even compile with mbed-os-example-client now, we must have the A3 defined - it is one of the standard Arduine header pins. Therefore, setting it as NC. A4-A5 are not connected either, so adding them as "NC" as well. Realtek will hopefully push a proper fix sooner or later, if there is a more meaningful define for the A3 pin. They do state however that the A0-A3 pins are not GPIO capable anyway. Ref: https://os.mbed.com/platforms/Realtek-RTL8195AM/
2739600
to
791343a
Compare
Added A4-A5 as NC, too. |
@JanneKiiskila The code freeze for the next patch release is close of play tomorrow. This needs to be reviewed, pass CI and be merged before that time if it is to make it in... |
@ARMmbed/team-realtek |
/morph build |
Build : SUCCESSBuild number : 623 Triggering tests/morph test |
Test : SUCCESSBuild number : 445 |
Exporter Build : SUCCESSBuild number : 250 |
Good to merge then? |
I'm new to mbed, and I followed a link from #5545 here. It looks like a change was made, approved and merged, but this code doesn't build for the RTL8195AM platform. The Jenkins file has that platform disabled. What am I missing? |
@daguro Can you provide more details ? IT does not build is not sufficient . toolchains, mbed OS version (sha if master is used), etc - everything a person needs to reproduce this locally. It would be good to file a new issiue with description where you can reference this PR if that is causing a problem (have you tried to build without this patch?).
|
Yes, I'll try to get that today. |
I am using the online mbed compiler. I am able to build mbed-os-example-wifi for the Nucleo 401 board. I am not able to build it for the RTL8195 Arduino-ish board. I note the the Jenkins file says that it building it is disabled. In the mbed_app.json file, I used the values of "internal" (as noted in the file) and "builtin" as noted in Jenkins file. Neither one worked. I get the following errors: Internal Error - Error number 0 |
Yep, it seems to fail - but I'd be hard pressed to accept this PR as the reason for it.
I think that's leading to some root cause, I think the on-line compiler generates those @thegecko @immunda - care to give it a look, easy to repo. Reverting to older version of Mbed OS - for example with 5.6.0 I get this:
It some kind of tool chain issue with this board. |
I'm not aware of the online compiler creating these sorts of files. Please raise an issue through the usual channels for investigation in the online compiler. |
As an issue against mbed-os or? I don't think the usual channel is that obvious for any stranger using the on-line compiler, there's no direct help topic on that as far as I can see. |
Raised issue: #5976 |
Description
Based on the Mbed OS website the A3 is connected to "DAC", however there
is no define for DAC. In order to get the Realtek RTL8195AM to even compile
with mbed-os-example-client now, we must have the A3 defined - it is one of
the standard Arduino header pins. Therefore, setting it as NC.
Realtek will hopefully push a proper fix sooner or later, if there is a
more meaningful define for the A3 pin. They do state however that the
A0-A3 pins are not GPIO capable anyway.
Ref: https://os.mbed.com/platforms/Realtek-RTL8195AM/
Notes:
Status
READY
With the caveat that Realtek might want to map A3 into something else than NC. But than can / should come as a separate PR in order to unblock us now.
Migrations
NO
Related PRs
Todos