Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtek RTL8195AM A3 fix #5611

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Conversation

JanneKiiskila
Copy link
Contributor

@JanneKiiskila JanneKiiskila commented Nov 28, 2017

Description

Based on the Mbed OS website the A3 is connected to "DAC", however there
is no define for DAC. In order to get the Realtek RTL8195AM to even compile
with mbed-os-example-client now, we must have the A3 defined - it is one of
the standard Arduino header pins. Therefore, setting it as NC.

Realtek will hopefully push a proper fix sooner or later, if there is a
more meaningful define for the A3 pin. They do state however that the
A0-A3 pins are not GPIO capable anyway.

Ref: https://os.mbed.com/platforms/Realtek-RTL8195AM/

Notes:

  • Pull requests will not be accepted until the submitter has agreed to the contributer agreement.
  • This is just a template, so feel free to use/remove the unnecessary things

Status

READY

With the caveat that Realtek might want to map A3 into something else than NC. But than can / should come as a separate PR in order to unblock us now.

Migrations

NO

Related PRs

Todos

  • Tests
  • Documentation

@JanneKiiskila
Copy link
Contributor Author

@tung7970 - please review.

@JanneKiiskila
Copy link
Contributor Author

@adbridge - I'd like to get this to next Mbed OS patch release, please.

@samchuarm
Copy link

@Archcady

Based on the Mbed OS website the A3 is connected to "DAC", however there
is no define for DAC. In order to get the Realtek RTL8195AM to even compile
with mbed-os-example-client now, we must have the A3 defined - it is one of
the standard Arduine header pins. Therefore, setting it as NC.

A4-A5 are not connected either, so adding them as "NC" as well.

Realtek will hopefully push a proper fix sooner or later, if there is a
more meaningful define for the A3 pin. They do state however that the
A0-A3 pins are not GPIO capable anyway.

Ref: https://os.mbed.com/platforms/Realtek-RTL8195AM/
@JanneKiiskila
Copy link
Contributor Author

Added A4-A5 as NC, too.

@adbridge
Copy link
Contributor

@JanneKiiskila The code freeze for the next patch release is close of play tomorrow. This needs to be reviewed, pass CI and be merged before that time if it is to make it in...

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 29, 2017

@ARMmbed/team-realtek

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 30, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 30, 2017

Build : SUCCESS

Build number : 623
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5611/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 30, 2017

@mbed-ci
Copy link

mbed-ci commented Nov 30, 2017

@JanneKiiskila
Copy link
Contributor Author

Good to merge then?

@0xc0170 0xc0170 merged commit 6d50868 into ARMmbed:master Nov 30, 2017
@daguro
Copy link

daguro commented Jan 30, 2018

I'm new to mbed, and I followed a link from #5545 here.

It looks like a change was made, approved and merged, but this code doesn't build for the RTL8195AM platform.

The Jenkins file has that platform disabled.

What am I missing?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 30, 2018

@daguro Can you provide more details ? IT does not build is not sufficient . toolchains, mbed OS version (sha if master is used), etc - everything a person needs to reproduce this locally.

It would be good to file a new issiue with description where you can reference this PR if that is causing a problem (have you tried to build without this patch?).

#master branch 
cf5065c31 - (HEAD -> master, upstream/master) Merge pull request #5901 from cmens23/netbeans_exporter

# GCC 6 used, to build a test
mbed test -m REALTEK_RTL8195AM -t GCC_ARM -n tests-mbedmicro-rtos-mbed-semaphore
......
Build successes:
  * REALTEK_RTL8195AM::GCC_ARM::MBED-BUILD
  * REALTEK_RTL8195AM::GCC_ARM::TESTS-MBEDMICRO-RTOS-MBED-SEMAPHORE

@JanneKiiskila JanneKiiskila deleted the rtl8195am-a3-fix branch January 30, 2018 11:14
@daguro
Copy link

daguro commented Jan 30, 2018

Yes, I'll try to get that today.

@daguro
Copy link

daguro commented Jan 30, 2018

I am using the online mbed compiler.

I am able to build mbed-os-example-wifi for the Nucleo 401 board.

I am not able to build it for the RTL8195 Arduino-ish board.

I note the the Jenkins file says that it building it is disabled.

In the mbed_app.json file, I used the values of "internal" (as noted in the file) and "builtin" as noted in Jenkins file. Neither one worked.

I get the following errors:

Internal Error - Error number 0
Compiler Task Failed: Error number -242

@JanneKiiskila
Copy link
Contributor Author

JanneKiiskila commented Jan 30, 2018

Yep, it seems to fail - but I'd be hard pressed to accept this PR as the reason for it.
It's super critical to mention the compiler environment etc., as we can't guess what you would be using. This seems like an on-line compiler specific issue. I raised an PR on the mbed-os-example-wifi Jenkinsfile to get it back up'n'running as well, so that's not the reason for this.

""/extras/mbed_5e5da4a5990b/LPC1768/ARM/LPC1768.sct", line 4 (column 9): Error: L6235E: More than one section matches selector - cannot all be FIRST/LAST." in file "/"

Look for multiple mbed.bld files in your program.

I think that's leading to some root cause, I think the on-line compiler generates those .bld files by itself, as the sources should not have any .bld files.

@thegecko @immunda - care to give it a look, easy to repo.

Reverting to older version of Mbed OS - for example with 5.6.0 I get this:

Error: "/extras/mbed-os.lib/targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/device/TOOLCHAIN_ARM_STD/rtl8195a.sct", line 16 (column 22): Error: L6236E: No section matches selector - no section to be FIRST/LAST.

It some kind of tool chain issue with this board.

@thegecko
Copy link
Member

I'm not aware of the online compiler creating these sorts of files. Please raise an issue through the usual channels for investigation in the online compiler.

@JanneKiiskila
Copy link
Contributor Author

As an issue against mbed-os or? I don't think the usual channel is that obvious for any stranger using the on-line compiler, there's no direct help topic on that as far as I can see.

@JanneKiiskila
Copy link
Contributor Author

Raised issue: #5976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants