-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct Realtek post-build script to work in the online compiler #6216
Conversation
@JanneKiiskila Do you think you could review/test this really quick? It's a small change and once merged, we could close the Online Compiler bug. |
@cmonr This change is already live in the online complier, so we could mark the bug fixed now. This is the "up-streaming" effort. |
Ah, nice. Is the "partnerbeta" thing something that we could publicly link here? If not, then that's fine. |
/morph build |
Build : FAILUREBuild number : 1367 |
Looks like it did not like compiling LWIP. Also, there are quite a few TypeErrors. |
Is anything needed from Realtek side to address? |
Not yet. I have to figure out what when wrong with those 3 builds. |
b089a4b
to
a9e3a4f
Compare
/morph build |
Build : SUCCESSBuild number : 1471 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1117 |
Test : FAILUREBuild number : 1248 |
/morph test |
Test : SUCCESSBuild number : 1255 |
Resolves #5976