New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Realtek post-build script to work in the online compiler #6216

Merged
merged 1 commit into from Mar 19, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Feb 26, 2018

Resolves #5976

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

@JanneKiiskila Do you think you could review/test this really quick? It's a small change and once merged, we could close the Online Compiler bug.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 6, 2018

@cmonr This change is already live in the online complier, so we could mark the bug fixed now. This is the "up-streaming" effort.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

Ah, nice. Is the "partnerbeta" thing something that we could publicly link here? If not, then that's fine.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 6, 2018

@cmonr cmonr added needs: work and removed needs: review labels Mar 6, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

Looks like it did not like compiling LWIP. Also, there are quite a few TypeErrors.

@samchuarm

This comment has been minimized.

samchuarm commented Mar 12, 2018

@samchuarm

This comment has been minimized.

samchuarm commented Mar 12, 2018

Is anything needed from Realtek side to address?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 12, 2018

Not yet. I have to figure out what when wrong with those 3 builds.

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:fix-online-realtek branch from b089a4b to a9e3a4f Mar 16, 2018

@theotherjimmy theotherjimmy added needs: CI and removed needs: work labels Mar 16, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 16, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 16, 2018

Build : SUCCESS

Build number : 1471
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6216/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 19, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 19, 2018

@cmonr cmonr merged commit e01479c into ARMmbed:master Mar 19, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment