Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Realtek post-build script to work in the online compiler #6216

Merged
merged 1 commit into from Mar 19, 2018

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Feb 26, 2018

Resolves #5976

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

@JanneKiiskila Do you think you could review/test this really quick? It's a small change and once merged, we could close the Online Compiler bug.

@theotherjimmy
Copy link
Contributor Author

@cmonr This change is already live in the online complier, so we could mark the bug fixed now. This is the "up-streaming" effort.

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

Ah, nice. Is the "partnerbeta" thing something that we could publicly link here? If not, then that's fine.

cmonr
cmonr previously approved these changes Mar 6, 2018
@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 6, 2018

Build : FAILURE

Build number : 1367
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6216/

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

Looks like it did not like compiling LWIP. Also, there are quite a few TypeErrors.

@samchuarm
Copy link

@prashantrar

@samchuarm
Copy link

Is anything needed from Realtek side to address?

@theotherjimmy
Copy link
Contributor Author

Not yet. I have to figure out what when wrong with those 3 builds.

@cmonr
Copy link
Contributor

cmonr commented Mar 16, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2018

Build : SUCCESS

Build number : 1471
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6216/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 17, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 17, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 19, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Mar 19, 2018

@cmonr cmonr merged commit e01479c into ARMmbed:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants