MIMXRT1050: Update to EVK Rev B #7105

mmahadevan108 · 2018-06-04T13:11:30Z

Description

Add the IVT header to the binary as this is required for boot up
This was earlier added by the DAPLink firmware. As it is no longer
handled in DAPLink, the header needs to be added inside mbed.
Update drivers
Uses the SDRAM for data section, stack and heap
EVK Rev A boards would continue to work, however you would need to update the DAPLink Interface firmware to the latest. Binary is available for download from www.nxp.com/opensda

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

mmahadevan108 · 2018-06-04T13:11:49Z

cc @maclobdell @0xc0170

mmahadevan108 · 2018-06-04T13:17:08Z

All mbed tests pass except for the below with GCC_ARM toolchain:

I am seeing a weird behavior when running the mbed test ‘tests-mbed_platform-error_handling’ using GCC_ARM toolchain.

1527872989.41][CONN][RXD] >>> Running case #3: 'Test error context capture'...
1527872989.47][CONN][INF] found KV pair in stream: {{__testcase_start;Test error context capture}}, queued...
1527872989.51][CONN][RXD] :127::FAIL: Expected 2147490068 Was 2147490068
1527872989.57][CONN][INF] found KV pair in stream: {{__testcase_finish;Test error context capture;0;1}}, queued...
1527872989.65][CONN][RXD] >>> 'Test error context capture': 0 passed, 1 failed with reason 'Assertion Failed'

As seen above the expected and actual seem to match, however the test is throwing this as an error. This is only seen with GCC_ARM toolchain.

0xc0170 · 2018-06-11T12:05:33Z

I am seeing a weird behavior when running the mbed test ‘tests-mbed_platform-error_handling’ using GCC_ARM toolchain.

How can we reproduce this error ? Is this error only visible after this update or also current master branch ?
cc @SenRamakri

0xc0170

LGTM but failing tests should be fixed

mmahadevan108 · 2018-06-11T16:17:27Z

I need some guidance on the failure. I do not see it with ARM and IAR toolchains.

Also I do not see if on other platforms with GCC_ARM.

cmonr · 2018-06-12T03:10:30Z

@mmahadevan108 A shot in the dark. The failure might be a comparison between ((uint32_t) -1) and ((char) -1), or something equivalent, and htrun is up-casting the value.

mmahadevan108 · 2018-06-12T19:20:41Z

I add the below change and see the tests pass with GCC_ARM

diff --git a/TESTS/mbed_platform/error_handling/main.cpp b/TESTS/mbed_platform/error_handling/main.cpp
index 008033c3d..a09493d23 100644
--- a/TESTS/mbed_platform/error_handling/main.cpp
+++ b/TESTS/mbed_platform/error_handling/main.cpp
@@ -124,7 +124,7 @@ void test_error_context_capture()
mbed_error_status_t status = mbed_get_last_error_info( &error_ctx );
TEST_ASSERT(status == MBED_SUCCESS);
TEST_ASSERT_EQUAL_UINT(error_value, error_ctx.error_value);
- TEST_ASSERT_EQUAL_UINT(osThreadGetId(), error_ctx.thread_id);
+ TEST_ASSERT_EQUAL_UINT((uint32_t)osThreadGetId(), error_ctx.thread_id);

Discovered via #7105. If both values are negative values, they are casted in such a way that -1 != -1. This small commit fixes that.

mmahadevan108 · 2018-06-14T16:42:14Z

Any update on this PR?

cmonr · 2018-06-14T16:43:54Z

@mmahadevan108 My understanding was that this was waiting on #7202 to come in first.

cmonr · 2018-06-15T00:23:03Z

@mmahadevan108 Aaand it's in! Rebase when you can and we can get CI started.

Discovered via #7105. If both values are negative values, they are casted in such a way that -1 != -1. This small commit fixes that.

mmahadevan108 · 2018-06-15T14:13:00Z

Thanks. I have rebased and updated the PR. I can confirm that all tests passed with all toolchains.

cmonr · 2018-06-15T21:56:33Z

/morph build

mbed-ci · 2018-06-15T23:29:58Z

Build : SUCCESS

Build number : 2358
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7105/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-16T01:44:21Z

Exporter Build : FAILURE

Build number : 1983
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7105/

mbed-ci · 2018-06-16T02:15:59Z

Test : FAILURE

Build number : 2146
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7105/2146

0xc0170 · 2018-06-18T08:13:35Z

/morph test
/morph export-build

cmonr

LGTM. Just some non-blockign comments.

cmonr · 2018-06-18T17:51:58Z

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/TARGET_EVK/fsl_clock_config.c

+ */
+
+/* TEXT BELOW IS USED AS SETTING FOR TOOLS *************************************
+!!GlobalInfo


Interesting. First time I've seen YAML used inside of a source file.

cmonr · 2018-06-18T17:52:49Z

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/TARGET_EVK/fsl_clock_config.c

@@ -1,8 +1,11 @@
 /*
+ * The Clear BSD License


Making a note here that this is compatible with our Apache 2 licensing.

https://spdx.org/licenses/BSD-3-Clause-Clear.html

cmonr · 2018-06-18T17:54:44Z

...ET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/TARGET_EVK/xip/evkbimxrt1050_sdram_ini_dcd.c

+/*************************************
+ *  DCD Data
+ *************************************/
+const uint8_t dcd_data[] = {


Was there any particular reason why this wasn't bunched up into multi-entry lines?

No idea, maybe it was separated out for clarity. I do not want to make changes to this file as it comes from the SDK team and is used by the ROM code to initialize SDRAM during boot.

mbed-ci · 2018-06-18T18:37:26Z

Build : SUCCESS

Build number : 2373
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7105/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-18T20:11:08Z

Exporter Build : FAILURE

Build number : 2006
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7105/

mmahadevan108 · 2018-06-18T20:15:49Z

I undid the change to this file to revert back to the previous value. However exporter still fails for IAR, any idea why?

mbed-ci · 2018-06-19T00:20:09Z

Test : SUCCESS

Build number : 2162
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7105/2162

mmahadevan108 · 2018-06-19T15:55:34Z

@cmonr Anything else needed for this PR?

cmonr · 2018-06-20T02:32:01Z

@mmahadevan108 We're still looking into this. Assuming that the MIMXRT1052xxx6A is supported by IAR 7, I don't see yet why this is still failing.

mmahadevan108 · 2018-06-20T13:22:52Z

Support for MIMXRT1052xxx6A was added in IAR 8.20.1. Was this exporter test added recently, it was not highlighted when the initial commit for MXRT was added in Dec 2017.

0xc0170 · 2018-06-21T08:56:47Z

Nothing new, I reviewed that PR back in February, seems like the example did not do anything there but passed as result, see http://mbed-os.s3-eu-west-1.amazonaws.com/builds/exporter/5826/PASS/MIMXRT1050_EVK/iar/060daa99c93aaa7ed40318c8e168f15bb12938d8_exporter_build_log_MIMXRT1050_EVK_iar.txt (@studavekar please review). Make iar compiled though.

Support for MIMXRT1052xxx6A was added in IAR 8.20.1

This is the issue. If that is true, this would become dependent on updating to the IAR 8.

cmonr · 2018-06-21T18:21:30Z

@mmahadevan108 I think the reason that this wasn't originally an issue was because as of right now, exporting to IAR for this particular target is disabled for IAR. At least, this is what is indicated by running mbed export --supported |grep "MIMXRT1050_EVK\|Platform"

Support for MIMXRT1052xxx6A was added in IAR 8.20.1

If this support wasn't also included in IAR 7, then we can't take in the part of the changeset that specifies the target MCU. Otherwise we'll keep on seeing

Updating build tree...
WTD: Unavailable option selection: 'NXP MIMXRT1052xxx6A'.

I think if the change in tools/export/iar/iar_definitions.json is reverted, this PR should be able to pass the IAR export text by reverting to the current behavior of not actually being able to export to IAR 7.

1. Add the IVT header to the binary as this is required for boot up This was earlier added by the DAPLink firmware. As it is no longer handled in DAPLink, the header needs to be added inside mbed. 2. Update drivers Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>

mmahadevan108 · 2018-06-21T18:36:03Z

Updated PR to remove IAR exporter support.

cmonr · 2018-06-21T23:18:08Z

/morph build

mbed-ci · 2018-06-22T00:15:55Z

Build : SUCCESS

Build number : 2428
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7105/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-22T01:43:04Z

Exporter Build : SUCCESS

Build number : 2057
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7105/

mbed-ci · 2018-06-22T07:25:17Z

Test : SUCCESS

Build number : 2208
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7105/2208

0xc0170 added the needs: review label Jun 4, 2018

0xc0170 previously approved these changes Jun 11, 2018

View reviewed changes

mmahadevan108 dismissed 0xc0170’s stale review via cb78dfc June 12, 2018 12:30

mmahadevan108 force-pushed the mxrt_add_ivt branch from e5e49ae to cb78dfc Compare June 12, 2018 12:30

cmonr added a commit that referenced this pull request Jun 13, 2018

Corrected casting issue with an assert within the error_handling test

6fa5609

Discovered via #7105. If both values are negative values, they are casted in such a way that -1 != -1. This small commit fixes that.

cmonr mentioned this pull request Jun 13, 2018

Corrected casting issue with an assert within the error_handling test #7202

Merged

cmonr added the needs: preceding PR label Jun 13, 2018

cmonr removed the needs: preceding PR label Jun 15, 2018

adbridge pushed a commit that referenced this pull request Jun 15, 2018

Corrected casting issue with an assert within the error_handling test

bed8207

Discovered via #7105. If both values are negative values, they are casted in such a way that -1 != -1. This small commit fixes that.

mmahadevan108 force-pushed the mxrt_add_ivt branch from cb78dfc to 8a60895 Compare June 15, 2018 13:06

cmonr added needs: CI and removed needs: review labels Jun 15, 2018

cmonr previously approved these changes Jun 15, 2018

View reviewed changes

cmonr added the release-version: 5.9.2 label Jun 15, 2018

cmonr previously approved these changes Jun 18, 2018

View reviewed changes

mmahadevan108 dismissed cmonr’s stale review via db22519 June 19, 2018 16:17

mmahadevan108 force-pushed the mxrt_add_ivt branch 2 times, most recently from db22519 to 7030426 Compare June 19, 2018 16:39

mmahadevan108 force-pushed the mxrt_add_ivt branch from 7030426 to 632892d Compare June 21, 2018 18:34

cmonr approved these changes Jun 21, 2018

View reviewed changes

cmonr added needs: CI release-version: 5.9.2 and removed needs: work labels Jun 21, 2018

0xc0170 added ready for merge and removed needs: CI labels Jun 22, 2018

cmonr merged commit 24daf18 into ARMmbed:master Jun 22, 2018

0xc0170 removed the ready for merge label Jun 22, 2018

mmahadevan108 deleted the mxrt_add_ivt branch July 4, 2018 13:16

cmonr mentioned this pull request Aug 27, 2018

NUCLEO_L4R5ZI: add new platform #7585

Merged

MIMXRT1050: Update to EVK Rev B #7105

MIMXRT1050: Update to EVK Rev B #7105

Conversation

mmahadevan108 commented Jun 4, 2018

Description

Pull request type

mmahadevan108 commented Jun 4, 2018

mmahadevan108 commented Jun 4, 2018

0xc0170 commented Jun 11, 2018

0xc0170 left a comment

Choose a reason for hiding this comment

mmahadevan108 commented Jun 11, 2018

cmonr commented Jun 12, 2018

mmahadevan108 commented Jun 12, 2018 • edited Loading

mmahadevan108 commented Jun 14, 2018

cmonr commented Jun 14, 2018

cmonr commented Jun 15, 2018

mmahadevan108 commented Jun 15, 2018

cmonr commented Jun 15, 2018

mbed-ci commented Jun 15, 2018

Triggering tests

mbed-ci commented Jun 16, 2018

mbed-ci commented Jun 16, 2018

0xc0170 commented Jun 18, 2018

cmonr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbed-ci commented Jun 18, 2018

Triggering tests

mbed-ci commented Jun 18, 2018

mmahadevan108 commented Jun 18, 2018

mbed-ci commented Jun 19, 2018

mmahadevan108 commented Jun 19, 2018

cmonr commented Jun 20, 2018

mmahadevan108 commented Jun 20, 2018 • edited Loading

0xc0170 commented Jun 21, 2018

cmonr commented Jun 21, 2018

mmahadevan108 commented Jun 21, 2018

cmonr commented Jun 21, 2018

mbed-ci commented Jun 22, 2018

Triggering tests

mbed-ci commented Jun 22, 2018

mbed-ci commented Jun 22, 2018

mmahadevan108 commented Jun 12, 2018 •

edited

Loading

mmahadevan108 commented Jun 20, 2018 •

edited

Loading