New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIMXRT1050: Update to EVK Rev B #7105

Merged
merged 1 commit into from Jun 22, 2018

Conversation

Projects
None yet
4 participants
@mmahadevan108
Contributor

mmahadevan108 commented Jun 4, 2018

Description

  1. Add the IVT header to the binary as this is required for boot up
    This was earlier added by the DAPLink firmware. As it is no longer
    handled in DAPLink, the header needs to be added inside mbed.
  2. Update drivers
  3. Uses the SDRAM for data section, stack and heap
  4. EVK Rev A boards would continue to work, however you would need to update the DAPLink Interface firmware to the latest. Binary is available for download from www.nxp.com/opensda

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jun 4, 2018

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jun 4, 2018

All mbed tests pass except for the below with GCC_ARM toolchain:

I am seeing a weird behavior when running the mbed test ‘tests-mbed_platform-error_handling’ using GCC_ARM toolchain.

1527872989.41][CONN][RXD] >>> Running case #3: 'Test error context capture'...
1527872989.47][CONN][INF] found KV pair in stream: {{__testcase_start;Test error context capture}}, queued...
1527872989.51][CONN][RXD] :127::FAIL: Expected 2147490068 Was 2147490068
1527872989.57][CONN][INF] found KV pair in stream: {{__testcase_finish;Test error context capture;0;1}}, queued...
1527872989.65][CONN][RXD] >>> 'Test error context capture': 0 passed, 1 failed with reason 'Assertion Failed'

As seen above the expected and actual seem to match, however the test is throwing this as an error. This is only seen with GCC_ARM toolchain.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 11, 2018

I am seeing a weird behavior when running the mbed test ‘tests-mbed_platform-error_handling’ using GCC_ARM toolchain.

How can we reproduce this error ? Is this error only visible after this update or also current master branch ?
cc @SenRamakri

@0xc0170

LGTM but failing tests should be fixed

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jun 11, 2018

I need some guidance on the failure. I do not see it with ARM and IAR toolchains.

Also I do not see if on other platforms with GCC_ARM.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 12, 2018

@mmahadevan108 A shot in the dark. The failure might be a comparison between ((uint32_t) -1) and ((char) -1), or something equivalent, and htrun is up-casting the value.

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:mxrt_add_ivt branch from e5e49ae to cb78dfc Jun 12, 2018

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jun 12, 2018

I add the below change and see the tests pass with GCC_ARM

diff --git a/TESTS/mbed_platform/error_handling/main.cpp b/TESTS/mbed_platform/error_handling/main.cpp
index 008033c3d..a09493d23 100644
--- a/TESTS/mbed_platform/error_handling/main.cpp
+++ b/TESTS/mbed_platform/error_handling/main.cpp
@@ -124,7 +124,7 @@ void test_error_context_capture()
mbed_error_status_t status = mbed_get_last_error_info( &error_ctx );
TEST_ASSERT(status == MBED_SUCCESS);
TEST_ASSERT_EQUAL_UINT(error_value, error_ctx.error_value);
- TEST_ASSERT_EQUAL_UINT(osThreadGetId(), error_ctx.thread_id);
+ TEST_ASSERT_EQUAL_UINT((uint32_t)osThreadGetId(), error_ctx.thread_id);

cmonr added a commit that referenced this pull request Jun 13, 2018

Corrected casting issue with an assert within the error_handling test
Discovered via #7105.
If both values are negative values, they are casted in such a way that -1 != -1. This small commit fixes that.
@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jun 14, 2018

Any update on this PR?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 14, 2018

@mmahadevan108 My understanding was that this was waiting on #7202 to come in first.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 15, 2018

@mmahadevan108 Aaand it's in! Rebase when you can and we can get CI started.

adbridge added a commit that referenced this pull request Jun 15, 2018

Corrected casting issue with an assert within the error_handling test
Discovered via #7105.
If both values are negative values, they are casted in such a way that -1 != -1. This small commit fixes that.

adbridge added a commit that referenced this pull request Jun 15, 2018

Corrected casting issue with an assert within the error_handling test
Discovered via #7105.
If both values are negative values, they are casted in such a way that -1 != -1. This small commit fixes that.

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:mxrt_add_ivt branch from cb78dfc to 8a60895 Jun 15, 2018

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jun 15, 2018

Thanks. I have rebased and updated the PR. I can confirm that all tests passed with all toolchains.

@cmonr cmonr added needs: CI and removed needs: review labels Jun 15, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 15, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 15, 2018

Build : SUCCESS

Build number : 2358
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7105/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 18, 2018

/morph test
/morph export-build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 18, 2018

Build : SUCCESS

Build number : 2373
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7105/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jun 18, 2018

I undid the change to this file to revert back to the previous value. However exporter still fails for IAR, any idea why?

@mbed-ci

This comment has been minimized.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jun 19, 2018

@cmonr Anything else needed for this PR?

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:mxrt_add_ivt branch 2 times, most recently from db22519 to 7030426 Jun 19, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 20, 2018

@mmahadevan108 We're still looking into this. Assuming that the MIMXRT1052xxx6A is supported by IAR 7, I don't see yet why this is still failing.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jun 20, 2018

Support for MIMXRT1052xxx6A was added in IAR 8.20.1. Was this exporter test added recently, it was not highlighted when the initial commit for MXRT was added in Dec 2017.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 21, 2018

Nothing new, I reviewed that PR back in February, seems like the example did not do anything there but passed as result, see http://mbed-os.s3-eu-west-1.amazonaws.com/builds/exporter/5826/PASS/MIMXRT1050_EVK/iar/060daa99c93aaa7ed40318c8e168f15bb12938d8_exporter_build_log_MIMXRT1050_EVK_iar.txt (@studavekar please review). Make iar compiled though.

Support for MIMXRT1052xxx6A was added in IAR 8.20.1

This is the issue. If that is true, this would become dependent on updating to the IAR 8.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 21, 2018

@mmahadevan108 I think the reason that this wasn't originally an issue was because as of right now, exporting to IAR for this particular target is disabled for IAR. At least, this is what is indicated by running mbed export --supported |grep "MIMXRT1050_EVK\|Platform"

Support for MIMXRT1052xxx6A was added in IAR 8.20.1

If this support wasn't also included in IAR 7, then we can't take in the part of the changeset that specifies the target MCU. Otherwise we'll keep on seeing

Updating build tree...
WTD: Unavailable option selection: 'NXP MIMXRT1052xxx6A'.

I think if the change in tools/export/iar/iar_definitions.json is reverted, this PR should be able to pass the IAR export text by reverting to the current behavior of not actually being able to export to IAR 7.

MIMXRT1050: Update to EVK Rev B
1. Add the IVT header to the binary as this is required for boot up
   This was earlier added by the DAPLink firmware. As it is no longer
   handled in DAPLink, the header needs to be added inside mbed.
2. Update drivers

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:mxrt_add_ivt branch from 7030426 to 632892d Jun 21, 2018

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jun 21, 2018

Updated PR to remove IAR exporter support.

@cmonr

cmonr approved these changes Jun 21, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 22, 2018

Build : SUCCESS

Build number : 2428
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7105/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 22, 2018

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 22, 2018

@cmonr cmonr merged commit 24daf18 into ARMmbed:master Jun 22, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 919 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10522 cycles (+833 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@mmahadevan108 mmahadevan108 deleted the NXPmicro:mxrt_add_ivt branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment