New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUCLEO_L4R5ZI: add new platform #7585

Merged
merged 10 commits into from Oct 5, 2018

Conversation

Projects
None yet
10 participants
@bcostm
Contributor

bcostm commented Jul 24, 2018

Description

Add support of this board:
https://www.st.com/content/st_com/en/products/evaluation-tools/product-evaluation-tools/mcu-eval-tools/stm32-mcu-eval-tools/stm32-mcu-nucleo/nucleo-l4r5zi.html

All mbed-os-5 tests with ARM/GCC/IAR are PASS
test_report.zip

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/team-st-mcd Jul 24, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 6, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 6, 2018

Build : SUCCESS

Build number : 2736
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7585/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 6, 2018

What version of IAR does this target require ? Our CI IAR version fails to find a target.

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Aug 6, 2018

@mbed-ci

This comment has been minimized.

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Aug 6, 2018

Hi

What version of IAR does this target require ? Our CI IAR version fails to find a target.

I don't really know IAR, but quick google search indicates version 8.20.1 ?
http://netstorage.iar.com/SuppDB/Public/UPDINFO/012495/arm/doc/infocenter/readme.ENU.html

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 6, 2018

if that is correct (that MCU definition is only for IAR 8.x) , the version we do not support it at the moment. That would explain the exporters failure

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Aug 6, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Aug 6, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 6, 2018

typedef enum {
PA_0 = 0x00,
PA_0_ALT0 = PA_0 | ALT0,

This comment has been minimized.

@ashok-rao

ashok-rao Aug 13, 2018

Contributor

I like this a lot!! Opens up opportunity for multiplexing..

LED2 = PB_7, // Blue
LED3 = PB_14, // Red
LED4 = LED1,
LED_RED = LED3,

This comment has been minimized.

@ashok-rao

ashok-rao Aug 13, 2018

Contributor

Maybe create aliases for the Blue & Green as well (just for consistency..)?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 22, 2018

If there is no IAR 7 support for this target, we might need to park this PR (close it for now).
It would be good to identify upcoming targets and their IAR 7 vs IAR 8 support.

@bcostm

This comment has been minimized.

Contributor

bcostm commented Aug 27, 2018

I have launched all my tests using IAR V7.5 without any problem but the issue concerns the exporter only.

I searched also in IAR release notes and STM32L4R5/L4R7/L4R9/L4S5/L4S7/L4S9 devices have been added in IAR V8.20.1. Other devices like STM32L4R5xxx-P/L4R7xxx-P/L4R9xxx-P have been added in IAR V8.30.1.

Is the migration to IAR V8 planned on mbed soon ?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 27, 2018

@bcostm We're definitely getting more pressure and requests on when we'll migrate, but as of right now, I'm unaware of anything planned.

For this PR, I think you might be able to do something similar for another target, in that device-specific exporting is disabled for IAR: #7105 (comment)

@bcostm

This comment has been minimized.

Contributor

bcostm commented Aug 27, 2018

OK thanks for the hint. I'll do the same.

@bcostm bcostm force-pushed the bcostm:dev_NUCLEO_L4R5ZI branch from ec271b6 to 752d4af Aug 27, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 27, 2018

@screamerbg Whenever uVision needs a new CMSIS pack, it needs to be installed manually in the Windows exporter VM. Because this modifies a CI VM, changes are managed by the @ARMmbed/mbed-os-test team to make sure that the CI is kept stable.

As for the timing, this and other PRs got affected by 5.10 release activity. During the 5.10 release, we explicitly made sure to not update CI, which means we weren't able to apply the new CMSIS pack.

We're doing what we can to work through the backlog, like prioritizing the oldest PRs as well as PRs that carry a high importance. Feel free to suggest anything here or in emails.

@bulislaw

This comment has been minimized.

Member

bulislaw commented Sep 28, 2018

@bcostm @jeromecoutant sorry for the delay with this PR. We were in the release cycle, where the PRs targeting the release get priority and also we can't modify the CI during this time. I'll try to make sure that this is communicated better going forward, so you are aware why the PR is not progressing as smoothly as it should.

@ARMmbed/mbed-os-maintainers please prioritise this PR and merge it ASAP.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 28, 2018

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 28, 2018

Sorry, jumped the gun there. CI updates still need to be made.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 1, 2018

I am checking today with @ARMmbed/mbed-os-test-team to get specific date/time for the update.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 1, 2018

VM was updated,

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 1, 2018

Build : SUCCESS

Build number : 3204
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7585/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

IAR nodes went offline, had to aborted it. I will restart soon, checking if the nodes are back online

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

This new target passed uVision, we just need to fix CI exporters and restart the job 🙄

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 3, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 3, 2018

/morph export-build

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

License issue, will restart shortly

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 5, 2018

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 5, 2018

@0xc0170 0xc0170 merged commit f7f6d4d into ARMmbed:master Oct 5, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 625 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10342 cycles (+398 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Oct 5, 2018

@bcostm bcostm deleted the bcostm:dev_NUCLEO_L4R5ZI branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment