NUCLEO_L4R5ZI: add new platform #7585

bcostm · 2018-07-24T08:33:44Z

Description

Add support of this board:
https://www.st.com/content/st_com/en/products/evaluation-tools/product-evaluation-tools/mcu-eval-tools/stm32-mcu-eval-tools/stm32-mcu-nucleo/nucleo-l4r5zi.html

All mbed-os-5 tests with ARM/GCC/IAR are PASS
test_report.zip

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change

0xc0170 · 2018-08-06T09:24:17Z

/morph build

mbed-ci · 2018-08-06T11:00:39Z

Build : SUCCESS

Build number : 2736
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7585/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-08-06T12:24:14Z

Exporter Build : FAILURE

Build number : 2370
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7585/

0xc0170 · 2018-08-06T13:13:37Z

What version of IAR does this target require ? Our CI IAR version fails to find a target.

mbed-ci · 2018-08-06T13:36:58Z

Test : SUCCESS

Build number : 2463
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7585/2463

jeromecoutant · 2018-08-06T13:57:30Z

Hi

What version of IAR does this target require ? Our CI IAR version fails to find a target.

I don't really know IAR, but quick google search indicates version 8.20.1 ?
http://netstorage.iar.com/SuppDB/Public/UPDINFO/012495/arm/doc/infocenter/readme.ENU.html

0xc0170 · 2018-08-06T14:39:31Z

if that is correct (that MCU definition is only for IAR 8.x) , the version we do not support it at the moment. That would explain the exporters failure

jeromecoutant · 2018-08-06T14:41:38Z

@screamerbg

jeromecoutant · 2018-08-06T14:44:19Z

@marcuschangarm

cmonr · 2018-08-06T14:50:41Z

@ashok-rao

ashok-rao · 2018-08-13T10:07:29Z

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L4R5xI/TARGET_NUCLEO_L4R5ZI/PinNames.h

+typedef enum {
+
+    PA_0  = 0x00,
+    PA_0_ALT0 = PA_0 | ALT0,


I like this a lot!! Opens up opportunity for multiplexing..

ashok-rao · 2018-08-13T10:08:22Z

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L4R5xI/TARGET_NUCLEO_L4R5ZI/PinNames.h

+    LED2        = PB_7, // Blue
+    LED3        = PB_14, // Red
+    LED4        = LED1,
+    LED_RED     = LED3,


Maybe create aliases for the Blue & Green as well (just for consistency..)?

0xc0170 · 2018-08-22T12:25:07Z

If there is no IAR 7 support for this target, we might need to park this PR (close it for now).
It would be good to identify upcoming targets and their IAR 7 vs IAR 8 support.

bcostm · 2018-08-27T13:53:30Z

I have launched all my tests using IAR V7.5 without any problem but the issue concerns the exporter only.

I searched also in IAR release notes and STM32L4R5/L4R7/L4R9/L4S5/L4S7/L4S9 devices have been added in IAR V8.20.1. Other devices like STM32L4R5xxx-P/L4R7xxx-P/L4R9xxx-P have been added in IAR V8.30.1.

Is the migration to IAR V8 planned on mbed soon ?

cmonr · 2018-08-27T14:09:59Z

@bcostm We're definitely getting more pressure and requests on when we'll migrate, but as of right now, I'm unaware of anything planned.

For this PR, I think you might be able to do something similar for another target, in that device-specific exporting is disabled for IAR: #7105 (comment)

bcostm · 2018-08-27T14:17:04Z

OK thanks for the hint. I'll do the same.

bcostm · 2018-09-27T12:54:57Z

Rebased

cmonr · 2018-09-27T13:50:38Z

@screamerbg Whenever uVision needs a new CMSIS pack, it needs to be installed manually in the Windows exporter VM. Because this modifies a CI VM, changes are managed by the @ARMmbed/mbed-os-test team to make sure that the CI is kept stable.

As for the timing, this and other PRs got affected by 5.10 release activity. During the 5.10 release, we explicitly made sure to not update CI, which means we weren't able to apply the new CMSIS pack.

We're doing what we can to work through the backlog, like prioritizing the oldest PRs as well as PRs that carry a high importance. Feel free to suggest anything here or in emails.

bulislaw · 2018-09-28T11:18:08Z

@bcostm @jeromecoutant sorry for the delay with this PR. We were in the release cycle, where the PRs targeting the release get priority and also we can't modify the CI during this time. I'll try to make sure that this is communicated better going forward, so you are aware why the PR is not progressing as smoothly as it should.

@ARMmbed/mbed-os-maintainers please prioritise this PR and merge it ASAP.

cmonr · 2018-09-28T16:06:38Z

/morph build

cmonr · 2018-09-28T16:07:20Z

Sorry, jumped the gun there. CI updates still need to be made.

0xc0170 · 2018-10-01T07:37:35Z

I am checking today with @ARMmbed/mbed-os-test-team to get specific date/time for the update.

0xc0170 · 2018-10-01T12:15:42Z

VM was updated,

/morph build

mbed-ci · 2018-10-01T13:01:18Z

Build : SUCCESS

Build number : 3204
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7585/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-01T19:01:04Z

Test : SUCCESS

Build number : 3004
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7585/3004

mbed-ci · 2018-10-02T06:49:17Z

Exporter Build : ABORTED

Build number : 2796
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7585/

0xc0170 · 2018-10-02T06:55:03Z

IAR nodes went offline, had to aborted it. I will restart soon, checking if the nodes are back online

0xc0170 · 2018-10-02T09:16:55Z

This new target passed uVision, we just need to fix CI exporters and restart the job 🙄

NirSonnenschein · 2018-10-03T07:02:09Z

/morph export-build

mbed-ci · 2018-10-03T08:05:35Z

Exporter Build : FAILURE

Build number : 2805
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7585/

NirSonnenschein · 2018-10-03T14:02:05Z

/morph export-build

0xc0170 · 2018-10-04T15:21:47Z

/morph export-build

mbed-ci · 2018-10-04T16:36:16Z

Exporter Build : FAILURE

Build number : 2818
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7585/

0xc0170 · 2018-10-05T11:14:53Z

/morph export-build

mbed-ci · 2018-10-05T11:37:56Z

Exporter Build : ABORTED

Build number : 2825
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7585/

0xc0170 · 2018-10-05T11:49:09Z

License issue, will restart shortly

0xc0170 · 2018-10-05T11:50:50Z

/morph export-build

mbed-ci · 2018-10-05T12:49:00Z

Exporter Build : SUCCESS

Build number : 2827
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7585/

0xc0170 added needs: review scope: new-target labels Jul 24, 2018

0xc0170 requested a review from a team July 24, 2018 08:54

0xc0170 approved these changes Jul 25, 2018

View reviewed changes

0xc0170 added needs: CI needs: review and removed needs: review needs: CI labels Jul 25, 2018

jeromecoutant approved these changes Aug 6, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Aug 6, 2018

0xc0170 added needs: work and removed needs: CI labels Aug 6, 2018

ashok-rao reviewed Aug 13, 2018

View reviewed changes

bcostm force-pushed the dev_NUCLEO_L4R5ZI branch from ec271b6 to 752d4af Compare August 27, 2018 14:24

0xc0170 added the release-version: 5.10.2 label Oct 1, 2018

0xc0170 added release-version: 5.10.1 and removed release-version: 5.10.2 labels Oct 4, 2018

0xc0170 added ready for merge and removed needs: CI labels Oct 5, 2018

0xc0170 merged commit f7f6d4d into ARMmbed:master Oct 5, 2018

0xc0170 removed the ready for merge label Oct 5, 2018

bcostm deleted the dev_NUCLEO_L4R5ZI branch October 29, 2018 09:35

NUCLEO_L4R5ZI: add new platform #7585

NUCLEO_L4R5ZI: add new platform #7585

Conversation

bcostm commented Jul 24, 2018

Description

Pull request type

0xc0170 commented Aug 6, 2018

mbed-ci commented Aug 6, 2018

Triggering tests

mbed-ci commented Aug 6, 2018

0xc0170 commented Aug 6, 2018

mbed-ci commented Aug 6, 2018

jeromecoutant commented Aug 6, 2018

0xc0170 commented Aug 6, 2018

jeromecoutant commented Aug 6, 2018

jeromecoutant commented Aug 6, 2018

cmonr commented Aug 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xc0170 commented Aug 22, 2018

bcostm commented Aug 27, 2018

cmonr commented Aug 27, 2018

bcostm commented Aug 27, 2018

bcostm commented Sep 27, 2018

cmonr commented Sep 27, 2018

bulislaw commented Sep 28, 2018

cmonr commented Sep 28, 2018

cmonr commented Sep 28, 2018

0xc0170 commented Oct 1, 2018

0xc0170 commented Oct 1, 2018

mbed-ci commented Oct 1, 2018

Triggering tests

mbed-ci commented Oct 1, 2018

mbed-ci commented Oct 2, 2018

0xc0170 commented Oct 2, 2018

0xc0170 commented Oct 2, 2018

NirSonnenschein commented Oct 3, 2018

mbed-ci commented Oct 3, 2018

NirSonnenschein commented Oct 3, 2018

0xc0170 commented Oct 4, 2018

mbed-ci commented Oct 4, 2018

0xc0170 commented Oct 5, 2018

mbed-ci commented Oct 5, 2018

0xc0170 commented Oct 5, 2018

0xc0170 commented Oct 5, 2018

mbed-ci commented Oct 5, 2018