New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool: Use TerminalNotifier in Mbed 2 release #7132

Merged
merged 1 commit into from Jun 7, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Jun 5, 2018

Description

I missed this invocation of one of the build functions when migrating. Sorry!

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@0xc0170

0xc0170 approved these changes Jun 5, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 6, 2018

@cmonr We are missing here d743f7f commit that you added to the rc ?

@0xc0170 0xc0170 added the needs: work label Jun 6, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 6, 2018

@0xc0170 No, I think we're fine. The change that was applied on the PR branch was present in a different PR that already landed into master.

Both 5.9 and master branches already have the change, so this PR is fine asis.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 6, 2018

After comparing both branches, this PR is only really needed for master, since 5.9 already has these changes.

Keeping release label marked as rc2, just so this can land in master.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 6, 2018

/morph build

@cmonr

cmonr approved these changes Jun 6, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 6, 2018

Build : SUCCESS

Build number : 2252
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7132/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 7, 2018

@0xc0170 0xc0170 merged commit 835d38d into ARMmbed:master Jun 7, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 920 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10205 cycles (+258 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment