Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool: Use TerminalNotifier in Mbed 2 release #7132

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

I missed this invocation of one of the build functions when migrating. Sorry!

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2018

@cmonr We are missing here d743f7f commit that you added to the rc ?

@cmonr
Copy link
Contributor

cmonr commented Jun 6, 2018

@0xc0170 No, I think we're fine. The change that was applied on the PR branch was present in a different PR that already landed into master.

Both 5.9 and master branches already have the change, so this PR is fine asis.

@cmonr
Copy link
Contributor

cmonr commented Jun 6, 2018

After comparing both branches, this PR is only really needed for master, since 5.9 already has these changes.

Keeping release label marked as rc2, just so this can land in master.

@cmonr
Copy link
Contributor

cmonr commented Jun 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 6, 2018

Build : SUCCESS

Build number : 2252
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7132/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

@0xc0170 0xc0170 merged commit 835d38d into ARMmbed:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants