Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lora: Remove duplicate LinkCheckReq MAC command #7895

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Lora: Remove duplicate LinkCheckReq MAC command #7895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions features/lorawan/LoRaWANStack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ int16_t LoRaWANStack::handle_tx(const uint8_t port, const uint8_t *data,
// add a link check request with normal data, until the application
// explicitly removes it.
if (_link_check_requested) {
set_link_check_request();
_loramac.setup_link_check_request();
}

if (!_lw_session.active) {
Expand Down Expand Up @@ -442,13 +442,12 @@ lorawan_status_t LoRaWANStack::set_link_check_request()
return LORAWAN_STATUS_NOT_INITIALIZED;
}

_link_check_requested = true;
if (!_callbacks.link_check_resp) {
tr_error("Must assign a callback function for link check request. ");
return LORAWAN_STATUS_PARAMETER_INVALID;
}

_loramac.setup_link_check_request();
_link_check_requested = true;
return LORAWAN_STATUS_OK;
}

Expand Down