Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default Mbed OS error URI string #8053

Closed
wants to merge 1 commit into from
Closed

Fix default Mbed OS error URI string #8053

wants to merge 1 commit into from

Conversation

kjbracey
Copy link
Contributor

Description

Build warnings about illegal escape sequences were being generated - remove a stray C \ (escaped as JSON \\).

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@kjbracey
Fix default Mbed OS error URI string
f796fe4 
Build warnings about illegal escape sequences were being generated -
remove a stray C `\` (escaped as JSON `\\`).
adbridge
adbridge approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kjbracey kjbracey mentioned this pull request Sep 11, 2018
Closed
@kjbracey
Copy link
Contributor Author

Duplicate of #8040 - close one.

@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 16, 2018

Build : FAILURE

Build number : 3077
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8053/

@NirSonnenschein
Copy link
Contributor

re-try to make sure it is not a sporadic issue. failure in IAR is obviously not related to the changes in the PR
/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 16, 2018

Build : FAILURE

Build number : 3078
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8053/

@NirSonnenschein
Copy link
Contributor

stuck because of -11 IAR error

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2018

This should be fixed via #8017 (this change plus fixing IAR toolchain script)

@0xc0170 0xc0170 closed this Sep 17, 2018
@0xc0170 0xc0170 removed the needs: CI label Sep 17, 2018
@kjbracey kjbracey deleted the error_uri branch September 17, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kjbracey @NirSonnenschein @mbed-ci @0xc0170 @adbridge