Update the CC310 IAR libraries #9122

RonEld · 2018-12-17T12:17:27Z

Description

After testing the Mbed TLS On Target Tests with IAR, on NRF52840 platform, it was discovered that the Cryptocell library is not initiated correct. This fix replaces the libraries received by Mail, with libraries built from the official Cryptocell 310 release, version 1.1.0.1285, using IAR version 7.80.1.11864 and the NRF52840 platform registers base address.

Tested with GreenTea Mbed TLS On Target Tests.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

0xc0170 · 2018-12-17T12:20:18Z

Can this be captured in the readme for these libs (version of the code used, toolchain version). Same would be good to have inthe commit msg as well

RonEld · 2018-12-17T12:23:43Z

@0xc0170

Can this be captured in the readme for these libs (version of the code used, toolchain version). Same would be good to have inthe commit msg as well

In this case, I will update this PR with the ARM and GCC_ARM libraries as well, to be synced

ciarmcom · 2018-12-17T14:00:28Z

@RonEld, thank you for your changes.
@ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-maintainers please review.

RonEld · 2018-12-17T14:03:51Z

I am currently working on updating the other toolchain libraries for specific version information, and updating the readme file, as requested earlier.

yanesca

The changes are only binaries, there is nothing to review.

cmonr · 2018-12-17T16:55:53Z

Waiting on #9131 for a fix to Travis CI.

RonEld · 2018-12-17T20:42:02Z

I have amended the commit message with version information, and uploaded the libraries for ARM and GCC_ARM with the specific version information.
in addition, I have updated the Readme.md file with the version information. Should we ask someone from the docs team to review the changes in the readme?

0xc0170 · 2018-12-18T10:57:17Z

features/cryptocell/FEATURE_CRYPTOCELL310/Readme.md

+* The CC 310 libraries were built from version `arm_sw-cc310-1.1.0.1285`
+* The `IAR` libraries were built using `IAR ANSI C/C++ Compiler V7.80.1.11864/W32 for ARM` with `--cpu Cortex-M4f`.
+* The `ARM` libraries were built using `ARM Compiler 5.06 update 4 (build 422)` with `--cpu cortex-m4`.
+* The `GCC_ARM` libraries were built using `arm-none-eabi-gcc 7.3.1 20180622 (release)` with `-mcpu=cortex-m4`.


tested with GCC ARM 6 as that one is supported, this would rather be recompiled

Update the cryptocell 310 IAR libraries, since the previous ones were not built correct. The libraries were built from the Cryptocell 310 release version 1.1.0.1285, using IAR version 7.80.1.11864.

Update the cryptocell 310 ARM libraries with known version. The libraries were built from the Cryptocell 310 release version 1.1.0.1285, using `ARM Compiler 5.06 update 4 (build 422)`.

Update the cryptocell 310 GCC_ARM libraries with known version. The libraries were built from the Cryptocell 310 release version 1.1.0.1285, using arm-none-eabi-gcc 6.3.1 20170620 (release) (release).

Update the Cryptocell 310 readme file with the binary library version information.

RonEld · 2018-12-18T16:16:46Z

I removed the previous commit with the build with gcc 7.3.1
I amended 2446470 with the new version
I rebuilt the library with gcc 6.3.1, and uploaded it in a new commit

0xc0170

One remaining question: increase binary sizes (in case of IAR 240 percent reported by Github - is that correct) ?

You can check by viewing files in the PR, Github reports the size differences

RonEld · 2018-12-19T09:30:29Z

@0xc0170

One remaining question: increase binary sizes (in case of IAR 240 percent reported by Github - is that correct) ?

Since the previous IAR libraries were actually broken. I assume this is correct. I haven't built them, and they were built with wchar defined as short ( Probably for IAR 8 ). This could explain why it was broken, and why the size was smaller.

RonEld · 2018-12-19T10:18:17Z

@0xc0170

Should we ask someone from the docs team to review the changes in the readme?

mbed-ci · 2018-12-19T12:56:12Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

0xc0170 · 2018-12-19T13:07:24Z

@AnotherButler for later review, she is currently OoO. Reviewed by a maintainer should be sufficient for this change

Update the CC310 IAR libraries

ciarmcom requested review from a team December 17, 2018 14:00

ciarmcom added the needs: review label Dec 17, 2018

RonEld added needs: work and removed needs: review labels Dec 17, 2018

yanesca reviewed Dec 17, 2018

View reviewed changes

cmonr added the needs: preceding PR label Dec 17, 2018

RonEld force-pushed the update_cc310_iar_libs branch from 06ca95f to d89c7a0 Compare December 17, 2018 20:40

RonEld added needs: review and removed needs: work labels Dec 17, 2018

cmonr removed the needs: preceding PR label Dec 17, 2018

0xc0170 reviewed Dec 18, 2018

View reviewed changes

Ron Eldor added 4 commits December 18, 2018 18:04

Update the CC310 IAR libraries

3a651a1

Update the cryptocell 310 IAR libraries, since the previous ones were not built correct. The libraries were built from the Cryptocell 310 release version 1.1.0.1285, using IAR version 7.80.1.11864.

Update the CC310 ARM libraries

297c0e4

Update the cryptocell 310 ARM libraries with known version. The libraries were built from the Cryptocell 310 release version 1.1.0.1285, using `ARM Compiler 5.06 update 4 (build 422)`.

Update the CC310 GCC_ARM libraries

03a2e07

Update the cryptocell 310 GCC_ARM libraries with known version. The libraries were built from the Cryptocell 310 release version 1.1.0.1285, using arm-none-eabi-gcc 6.3.1 20170620 (release) (release).

Update the CC310 readme file

2446470

Update the Cryptocell 310 readme file with the binary library version information.

RonEld force-pushed the update_cc310_iar_libs branch from d89c7a0 to 2446470 Compare December 18, 2018 16:15

0xc0170 approved these changes Dec 19, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Dec 19, 2018

0xc0170 added ready for merge and removed needs: CI labels Dec 19, 2018

0xc0170 added the release-version: 5.11.1 label Dec 19, 2018

cmonr merged commit 2446470 into ARMmbed:master Dec 19, 2018

cmonr pushed a commit that referenced this pull request Dec 19, 2018

Merge pull request #9122 from RonEld/update_cc310_iar_libs

ac499ba

Update the CC310 IAR libraries

cmonr removed the ready for merge label Dec 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the CC310 IAR libraries #9122

Update the CC310 IAR libraries #9122

RonEld commented Dec 17, 2018 •

edited

Loading

0xc0170 commented Dec 17, 2018

RonEld commented Dec 17, 2018 •

edited

Loading

ciarmcom commented Dec 17, 2018

RonEld commented Dec 17, 2018

yanesca left a comment

cmonr commented Dec 17, 2018

RonEld commented Dec 17, 2018

0xc0170 Dec 18, 2018

RonEld commented Dec 18, 2018

0xc0170 left a comment •

edited

Loading

RonEld commented Dec 19, 2018

RonEld commented Dec 19, 2018

mbed-ci commented Dec 19, 2018

0xc0170 commented Dec 19, 2018

Update the CC310 IAR libraries #9122

Update the CC310 IAR libraries #9122

Conversation

RonEld commented Dec 17, 2018 • edited Loading

Description

Pull request type

0xc0170 commented Dec 17, 2018

RonEld commented Dec 17, 2018 • edited Loading

ciarmcom commented Dec 17, 2018

RonEld commented Dec 17, 2018

yanesca left a comment

Choose a reason for hiding this comment

cmonr commented Dec 17, 2018

RonEld commented Dec 17, 2018

0xc0170 Dec 18, 2018

Choose a reason for hiding this comment

RonEld commented Dec 18, 2018

0xc0170 left a comment • edited Loading

Choose a reason for hiding this comment

RonEld commented Dec 19, 2018

RonEld commented Dec 19, 2018

mbed-ci commented Dec 19, 2018

Test run: SUCCESS

0xc0170 commented Dec 19, 2018

RonEld commented Dec 17, 2018 •

edited

Loading

RonEld commented Dec 17, 2018 •

edited

Loading

0xc0170 left a comment •

edited

Loading