Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MBEDTLS_ENTROPY_NV_SEED to NUCLEO_F411RE to fix the build #9677

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
6 participants
@orenc17
Copy link
Contributor

commented Feb 12, 2019

Description

Add MBEDTLS_ENTROPY_NV_SEED to support psa_crypto on NUCLEO_F411RE

The platform does not have TRNG and must have a source of entropy to use psa-crypto

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Any other target that was fixed in #9605 needs this or only nucleo affected?

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

other target that

No, all the other have TRNG

@0xc0170 0xc0170 requested a review from ARMmbed/team-st-mcd Feb 12, 2019

@0xc0170 0xc0170 added the needs: CI label Feb 12, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Ci started

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

This fixes nightly client breakage from the last run

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 12, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@ARMmbed/team-st-mcd Please review. We would like to have this fix on master today to resolve nightly failure

@Patater

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

This may fix the build failure, but does the device work properly at run-time? Can a fresh F411 successfully initialize and use crypto functionality?

I'm OK with this PR as-is since it's important to fix the nightly build, but more follow up is needed as to how we want to handle entropy with F411 targets.

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

I got build failure for Nucleo_F411RE in PR #9571 is this related? It was not for nightly build though

http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/artifacts/9571/5/build-ARM/FAIL/NUCLEO_F411RE/

./features/device_key/source/DeviceKey.cpp
[Error] check_config.h@502,0:  #35: #error directive: "MBEDTLS_PSA_CRYPTO_C defined, but not all prerequisites"
[DEBUG] Return: 1
[DEBUG] Output: "./features/mbedtls/inc/mbedtls/check_config.h", line 502: Error:  #35: #error directive: "MBEDTLS_PSA_CRYPTO_C defined, but not all prerequisites"
[DEBUG] Output: ./features/device_key/source/DeviceKey.cpp: 0 warnings, 1 error
Failed to build library
@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Yes related, this needs to get in asap.

@cmonr cmonr merged commit 36e65d2 into ARMmbed:master Feb 12, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9910 cycles (+681 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 12, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

@cmonr @Patater We do not know, or have the man power to research that

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@cmonr @Patater We do not know, or have the man power to research that

So either we make sure this works or we revert also psa additions that caused this build failures

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

Fix went to 5.11.5 so this one as well

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Moved to 5.12 due to failures with 5.11 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.