New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor publishing into its own file #3

Merged
merged 8 commits into from Dec 4, 2018

Conversation

Projects
None yet
5 participants
@janfreyberg
Member

janfreyberg commented Dec 2, 2018

This allows for better testing

janfreyberg added some commits Dec 2, 2018

Factor publishing into its own file
This allows for better testing

@janfreyberg janfreyberg requested a review from liamcoatman Dec 2, 2018

Show resolved Hide resolved faculty_mill/publish.py Outdated
Show resolved Hide resolved faculty_mill/publish.py Outdated
Show resolved Hide resolved faculty_mill/publish.py Outdated
@janfreyberg

This comment has been minimized.

Member

janfreyberg commented Dec 4, 2018

All fixed!

@janfreyberg

This comment has been minimized.

Member

janfreyberg commented Dec 4, 2018

Hmmmmm I don't know why coveralls is not reporting anything

Show resolved Hide resolved .pre-commit-config.yaml Outdated
@janfreyberg

This comment has been minimized.

Member

janfreyberg commented Dec 4, 2018

Hmmmmm I don't know why coveralls is not reporting anything

I think there's a problem with coveralls at the moment.

@janfreyberg

This comment has been minimized.

Member

janfreyberg commented Dec 4, 2018

it's back 🎉

@janfreyberg janfreyberg merged commit 94a60a0 into master Dec 4, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+27.4%) to 35.616%
Details

@srstevenson srstevenson deleted the factor-out-publication branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment