Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pyenv shell instruction #15472

Closed
wants to merge 881 commits into from
Closed

Conversation

Netherquark
Copy link

Description

originally, the venv instruction would initialise a venv with the system Python version, which breaks the installation. adding the shell command fixes this.

Screenshots/videos:

Checklist:

AUTOMATIC1111 and others added 30 commits April 9, 2024 20:08
… the image is to have a standard environment that contains a pytorch version compatible with ROCm already. Also makes sure the mainline version of pytorch isn't used when installing it
@Netherquark Netherquark changed the base branch from master to dev April 9, 2024 14:43
@w-e-w
Copy link
Collaborator

w-e-w commented Apr 9, 2024

WTF what you clone the wiki and make a PR of it??????

@w-e-w w-e-w closed this Apr 9, 2024
@Netherquark
Copy link
Author

I wasn't sure how I should edit it, sorry for the mistake. Would appreciate guidance on how I can contribute to the wiki.

@w-e-w
Copy link
Collaborator

w-e-w commented Apr 9, 2024

We used to public editing of the wiki and you will see a edit button on the wiki page
but someone says something about search engines like google dose not indexing if the wiki is publicly accessible
and so is limited to only collaborators

and unfortunately GitHub does not support PR to the wiki
we have considered creating an automated workflow to make it possible to make PR to a different repository and automatically push it to the Wiki page
but no one has yet invest time yet to see how to make such a workflow

I don't use pyenv my self so I cant comferm if your edit command is good or not
I'll ask other to see if you change wiki is correct if so I can make the change for you

@Netherquark
Copy link
Author

thank you so much for the prompt response! sorry once again for the inconvenience.

@w-e-w
Copy link
Collaborator

w-e-w commented Apr 9, 2024

reading the docs I don't understand
https://github.com/pyenv/pyenv/blob/master/COMMANDS.md#pyenv-local
why isn't pyenv local enough?

pyenv local 3.10.6

Sets a local application-specific Python version by writing the version name to a .python-version file in the current directory. This version overrides the global version, and can be overridden itself by setting the PYENV_VERSION environment variable or with the pyenv shell command.

did you perhaps use pyenv shell x.x.x your self and so now the local and so is overriding the local command?
if so then I think this is a more of a "your issue"
if we tell people to run pyenv shell 3.10.6 it will just cause issues with people who uses pyenv

@Netherquark
Copy link
Author

Netherquark commented Apr 9, 2024

running the venv command after pyenv local 3.10.6 initialises a 3.12.2 (system python) venv for me. Here's my system information:

System:
  Kernel: 6.8.2-201.fsync.fc39.x86_64 arch: x86_64 bits: 64 compiler: gcc
    v: 2.40-14.fc39 clocksource: tsc avail: hpet,acpi_pm
    parameters: BOOT_IMAGE=(hd0,gpt8)/vmlinuz-6.8.2-201.fsync.fc39.x86_64
    root=UUID=<filter> ro quiet splash resume=UUID=<filter>
  Console: pty pts/1 wm: gnome-shell DM: GDM v: 45.0.1 Distro: Nobara Linux
    39 (GNOME Edition) base: Fedora 39
Info:
  Packages: pm: dpkg pkgs: 0 pm: flatpak pkgs: 37 Compilers: clang: 17.0.6
    gcc: 13.2.1 Shell: Sudo (sudo) v: 1.9.15p5 default: Bash v: 5.2.26
    running-in: gnome-terminal inxi: 3.3.33

the stable diffusion installer itself catches that 3.12.2 is being used and throws a warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet