-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include_init_images missing from StableDiffusionProcessingImg2Img #4989
Conversation
Does processing.py:739 need to be patched as well to pass through the arg? |
git history shows this was never added to img2img processing class in the first place and i'm sure it's not supposed to go there in the first place. In fact, tests still complete properly with both "include_init_images": True and "include_init_images": False. |
That would be you running another instance of webui while the old one is still running and blocking the port ;) |
-->It was...which is why I deleted the comment, in the hope nobody would see me for the fool I am 😉
|
This happens when the user is using some extensions such as sd-dynamic-prompts. And I confirmed that this pull can fix it. |
I can confirm that manually making this change in the file resolves the problem. |
I'm also hitting this error when using the API and having sd-dynamic-prompts installed. |
Getting the error that this would fix (painthua) when trying to add to an image created. Given the frequency of automatic1111 updates (in this ever changing world of ai stuff thats to be expected and not moaning about it) I am reluctant to edit files. Can this fix not be brought into the main branch? does it negatively affect anything? |
This happens only when the user is using sd-dynamic-prompts . Please run img2img_test.py with sd-dynamic-prompts installed and you might see the same error. |
just to confirm the fix works so here is me doing a video for the painthua developer to show the issue clearer than i could in text https://www.youtube.com/watch?v=_IrQ0eygfiw during the video he pinged me some possible solutions to fix it...which i tried to no avail. he then asked me to try the fix here...I was reluctant to edit my files as i know how swift the development moves...but was willing to do it as a test... https://www.youtube.com/watch?v=siRaWaHvDoE as you can see its a success. Is there a reason the two line hasnt been merged? it seems a simple solution but i am gessing there is a reason? |
…ssingImg2Img in API #4989
This fix worked for me. I just edited my file by hand -- I'll deal with a merge conflict later while updating lol |
with the b2f17dd commit the problem should be gone. |
The missing
include_init_images
causes painthua to crash; I could not find a reason this would have been removed on purpose, especially with tests still supplying that value:stable-diffusion-webui/test/img2img_test.py
Line 43 in 828438b
This PR adds it back with a default
False
as seen here:stable-diffusion-webui/modules/api/models.py
Line 109 in 828438b