Implemented AddVisit and DeleteVisit feature #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…markCommandParser to AddVisitCommandParser improvement: add JsonAdaptedVisit.java
…and save them in the json file
… chosen patient when user uses deleteVisit command only specifying index of patient feat(deleteVisit): add deleteVisit command to delete visit record by index when user uses deleteVisit command with both index of patient and index of report to be deleted
docs: checkstyle compliance
SQwQ
added
status.Ongoing
ReignOfComputer
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
Good progress for mid-milestone, may want to look at refactoring Person to Patient. To discuss how we want to structure Diagnosis and Remarks, perhaps.
100/100 for TypicalVisits test (good example on how Visit is structured, CC @gachia @Wingedevil @Q-gabe).
LGTM.
|
@gachia can you change the Coveralls threshold or remove it as a merge prerequisite? |
Done. Lowered Threshold for Coveralls. |
21 tasks
26 tasks
SQwQ
removed
the
status.Ongoing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddVisit
addVisit takes in index of person and formatted date (dd/mm/yyyy) and calls handleAddVisit function of MainWindow.
handleAddVisit function of MainWindow shows VisitRecordWindow, which is a form for the user to fill in.
Pressing the submit button/F2 key will call SaveVisitCommand which takes the index and date passed from AddVisitCommand and the user's input on the form to add new VisitReport with all the relevant fields filled in to the Person's VisitList.
Saved reports can be found in the addressbook.json file in the data folder
DeleteVisit
deleteVisit takes in index of the person and the index of the record to be deleted
Everytime deleteVisit is run, handleDeleteVisit function of MainWindow will run to show a list of VisitRecords of the chosen person.
If the second argument (index of the record) is empty, pop up list will still show up and no changes would be made to the chosen Person.