Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UG and UI update #95

Merged
merged 16 commits into from
Oct 29, 2019
Merged

UG and UI update #95

merged 16 commits into from
Oct 29, 2019

Conversation

SQwQ
Copy link

@SQwQ SQwQ commented Oct 29, 2019

docs: UG update
docs: fixed some copy-pasted comments

feat: List Empty prompt similar to HelpWindow is shown instead of empty VisitListPanel when chosen person for edit/deletevisit has no past records

chore: changed no index prompt messages for edit/deletevisit

UI: Changed display text for VisitList
… to null everytime add/edit/deletevisit is run after VISIT restarts
UI: Changed display message for addvisit/deletevisit/savevisit commands
UI: VisitListPanel of reports closes before form pop ups for edit.
feat: List Empty prompt similar to HelpWindow is shown instead of empty VisitListPanel when chosen person for edit/deletevisit has no past records
chore: changed no index prompt messages for edit/deletevisit
fix: checkstyle
@SQwQ SQwQ added documentation Improvements or additions to documentation v1.3 labels Oct 29, 2019
@SQwQ SQwQ added this to the v1.3 milestone Oct 29, 2019
@SQwQ SQwQ self-assigned this Oct 29, 2019
Copy link

@ReignOfComputer ReignOfComputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@Q-gabe Q-gabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UG update looks good, I'll edit the overall tone later during my final vet tomorrow. Thanks @SQwQ! LGTM. 😄

Copy link

@gachia gachia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does EmptyListWindow do or show?

@SQwQ
Copy link
Author

SQwQ commented Oct 29, 2019

what does EmptyListWindow do or show?

It just shows a helpwindow with a message that says no past records

Copy link

@gachia gachia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok LGTM. I'll update the EmptyListWindow UI when I can.

@SQwQ SQwQ merged commit 843ad53 into AY1920S1-CS2103T-F12-2:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation v1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants