Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greeting is not hidden when disabled in homeView options #82

Closed
gottsman opened this issue Nov 2, 2023 · 17 comments
Closed

Greeting is not hidden when disabled in homeView options #82

gottsman opened this issue Nov 2, 2023 · 17 comments
Assignees

Comments

@gottsman
Copy link
Contributor

gottsman commented Nov 2, 2023

Describe the bug
I have tried to disable the greeting message at the top of the interface. Adding the hidden option seems to have no affect on visibility.

Versions

  • Mushroom-Strategy: 1.0.1
  • HACS: 1.33
  • Mushroom: 3.2.2
  • Home Assistant: 2023.11.0

To Reproduce
Here is my current config:

strategy:
  type: custom:mushroom-strategy
  options:
    homeView:
      hidden:
        - Greeting
    chips:
      climate_count: false
      cover_count: false
views: []

Expected behavior
Expected to see a simpler interface without the greeting message

Screenshots
minimalist greeting

Additional context
Add any other context about the problem here.

@gottsman gottsman added the bug Something isn't working label Nov 2, 2023
@DigiLive
Copy link
Collaborator

DigiLive commented Nov 2, 2023

The entries are case sensitive.
Please try them without any capitals.

@gottsman
Copy link
Contributor Author

gottsman commented Nov 2, 2023

I tried the example from the README.md file located at Aalian's repo:
https://github.com/AalianKhan/mushroom-strategy#home-view-options

Even this example is not working for me - direct copy/paste

strategy:
  type: custom:mushroom-strategy
  options:
    homeView:
      hidden:
        - greeting
        - areasTitle
views: []

@DigiLive
Copy link
Collaborator

DigiLive commented Nov 2, 2023

Ok, thanks.
I will look into it.

@DigiLive DigiLive self-assigned this Nov 2, 2023
@DigiLive
Copy link
Collaborator

DigiLive commented Nov 2, 2023

Version 1.0.1 doesn't include this feature.

It seems HACS shows the readme of the latest commit instead of the released one.

If you want to use this feature, you'll have to copy the latest .js file in the dist directory to your Home Assistant instance manually.

(Remember to remove the compressed file and to refresh your client's cache)

I've reported the readme issue to HACS #3330

@DigiLive DigiLive removed the bug Something isn't working label Nov 3, 2023
@DigiLive
Copy link
Collaborator

DigiLive commented Nov 3, 2023

I've reported the problem of the readme to HACS.
Also, a new release which includes this and some other features is coming soon.

In the meanwhile you could choose to download main at the HACS integration of your Home Assistant instance. (See https://hacs.xyz/docs/faq/select_version/)

afbeelding

@gottsman Please let me know if downloading the main version works out for you.

@gottsman
Copy link
Contributor Author

gottsman commented Nov 3, 2023

Works as expected. The greeting is now hidden properly. Thanks for your quick response.

@gottsman gottsman closed this as completed Nov 3, 2023
@gottsman
Copy link
Contributor Author

Seems like I have broken something. After trying multiple installs/reinstalls, browsers and cache clearing, I am no longer able to get the example to work. Using the code "main" instead of 1.01.

Using the same example from above:

strategy:
  type: custom:mushroom-strategy
  options:
    homeView:
      hidden:
        - greeting
        - areasTitle
views: []

@gottsman gottsman reopened this Nov 15, 2023
@DigiLive
Copy link
Collaborator

DigiLive commented Nov 15, 2023

It seems like HACS doesn't always download the requested version.
You can verify the downloaded version in the upper-left corner:
afbeelding

You can keep trying to re-download or manually copy the attached file to /homeassistant/www/community/mushroom-strategy of your HASS instance.
Also extract its contents to the same directory and clear the cache.

mushroom-strategy.js.gz (6,547 bytes)

I've reported the issue to HACS #3345

@gottsman
Copy link
Contributor Author

Thanks. Its fixed again with the attached file. I will follow the HACS issue report.

@derekpurdy
Copy link

derekpurdy commented Jan 24, 2024

I assume this should be working with 2.0 that was just released? I still cannot get the greeting to hide.

strategy:
  type: custom:mushroom-strategy
  options:
    homeView:
      hidden:
        - greeting
views: []

@clowgg
Copy link

clowgg commented Jan 25, 2024

I assume this should be working with 2.0 that was just released? I still cannot get the greeting to hide.

strategy:
  type: custom:mushroom-strategy
  options:
    homeView:
      hidden:
        - greeting
views: []

Same here. Greeting doesn't hide, and the areas customisations don't work either.
(partial yaml file shown)

strategy:
  type: custom:mushroom-strategy
  options:
    areas:
      front_of_home_id:
        name: Front of Home
        icon: mdi:home
        icon_color: green
        order: 1
      entrance_id:
        name: Entrance
        icon: mdi:home-lightbulb
        icon_color: lime
        order: 2

@DigiLive
Copy link
Collaborator

The Wiki didn't include the changes of the home view option during development.

It should be home_view instead of homeView:

strategy:
  type: custom:mushroom-strategy
  options:
    home_view:
      hidden:
        - greeting
views: []

@DigiLive
Copy link
Collaborator

Same here. Greeting doesn't hide, and the areas customisations don't work either.

To customize areas, you'll need to provide the id which is given to an area by home assistant.
Change front_of_home_id to the actual id.

@DigiLive DigiLive reopened this Jan 25, 2024
@derekpurdy
Copy link

strategy:
  type: custom:mushroom-strategy
  options:
    home_view:
      hidden:
        - greeting
views: []

unfortunately this did not work either.

@clowgg
Copy link

clowgg commented Jan 25, 2024

Same here. Greeting doesn't hide, and the areas customisations don't work either.

To customize areas, you'll need to provide the id which is given to an area by home assistant. Change front_of_home_id to the actual id.

Is this the Area ID that you mean?

image

@DigiLive
Copy link
Collaborator

Is this the Area ID that you mean?

Yes.
But this is off-topic for this issue.
Please continue in discussions or open another issue.

@DigiLive
Copy link
Collaborator

#119 Created for v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants