Implement TupletSpellingSpecifier.preferred_denominator #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OLD. Method worked only with FixedDurationTuplet objects. NEW. Method works with FixedDurationTuplet objects and Tuplet objects. No change to public functionality.
Recall that Tuplet.preferred_denominator has existed for a long time. OLD. TupletSpellingSpecifier implemented no preferred_denominator property. This meant that most rhythm-makers were unable to access the Tuplet.preferred_denominator property. (The exception was the TupletRhythmMaker.preferred_denominator property, which was implemented only on TupletRhythmMaker). NEW. TupletSpellingSpecifier.preferred_denominator now exists. This means that all rhythm-makers will be able to access the Tuplet.preferred_denominator property. Note that as of this commit, only TupletRhythmMaker has integrated the TupletSpellingSpecifier.preferred_denominator property. Note that a future commit will be a breaking commit that will remove the old TupletRhythmMaker.preferred_denominator poperty in favor of the new TupletSpellingSpecifier.preferred_denominator property.
You can now use the TupletSpellingSpecifier.preferred_denominator property in all rhythm-makers. NEW. Functionality can be included in release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recall that Tuplet.preferred_denominator has existed for a long time.
OLD. TupletSpellingSpecifier implemented no preferred_denominator property.
This meant that most rhythm-makers were unable to access the
Tuplet.preferred_denominator property. (The exception was the
TupletRhythmMaker.preferred_denominator property, which was implemented only on
TupletRhythmMaker).
NEW. TupletSpellingSpecifier.preferred_denominator now exists. This means that
all rhythm-makers will be able to access the Tuplet.preferred_denominator
property. Note that as of this commit, only TupletRhythmMaker has integrated
the TupletSpellingSpecifier.preferred_denominator property.
Note that a future commit will be a breaking commit that will remove the old
TupletRhythmMaker.preferred_denominator poperty in favor of the new
TupletSpellingSpecifier.preferred_denominator property.