Skip to content

Commit

Permalink
Fixes hitting RCD effects when they're done (tgstation#77896)
Browse files Browse the repository at this point in the history
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good πŸ‘― πŸ‘―β€β™‚οΈ πŸ‘―β€β™€οΈ πŸŽ‰ πŸ–οΈ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
  • Loading branch information
iwishforducks authored and Absolucy committed May 3, 2024
1 parent 2aa602d commit 8afb10a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions code/game/objects/effects/temporary_visuals/miscellaneous.dm
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,8 @@
if (status == RCD_DECONSTRUCT)
qdel(src)
else
mouse_opacity = MOUSE_OPACITY_TRANSPARENT
obj_flags &= ~CAN_BE_HIT
icon_state = "rcd_end"
addtimer(CALLBACK(src, PROC_REF(end)), 15)

Expand Down

0 comments on commit 8afb10a

Please sign in to comment.