Fixes hitting RCD effects when they're done #77896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
Fix
|
You currently have a negative Fix/Feature pull request delta of -9. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
Mothblocks
approved these changes
Aug 24, 2023
comfyorange
added a commit
that referenced
this pull request
Aug 25, 2023
Jolly-66
pushed a commit
to TaleStation/TaleStation
that referenced
this pull request
Aug 29, 2023
) Original PR: tgstation/tgstation#77896 ----- ## About The Pull Request tgstation/tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl: --------- Co-authored-by: iwishforducks <65363339+iwishforducks@users.noreply.github.com>
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 1, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 2, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 3, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 3, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 3, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 5, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 5, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 7, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 8, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 9, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 12, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 12, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 13, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 15, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 17, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 17, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 20, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 20, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 20, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
May 31, 2024
## About The Pull Request tgstation#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing. ## Why It's Good For The Game fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝 ## Changelog :cl: fix: You should no longer attack RCD effects when they're done constructing. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
#77641 made it so that RCD effects can be hit while they're constructing to stop their construction. however, the construction effect itself lingers a bit after things are done constructing, allowing it to eat up clicks. this fixes it by removing the flag when it's done constructing.
Why It's Good For The Game
fix good 👯 👯♂️ 👯♀️ 🎉 🏖️ 🐝
Changelog
🆑
fix: You should no longer attack RCD effects when they're done constructing.
/:cl: