Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives engineers the RCD round start and nerfs its base abilities to compensate #77641

Merged
merged 4 commits into from Aug 17, 2023

Conversation

Mothblocks
Copy link
Member

@Mothblocks Mothblocks commented Aug 15, 2023

About The Pull Request

  • Gives engineers an RCD as part of their round start equipment
  • RCD by default will build/deconstruct slower if you already have another one in progress. This can be upgraded with the new cooling upgrade disk. Reconstructing (anything that was there roundstart as per the destructive scan) doesn't have this downside, only construction/deconstruction.
  • RCD construction effects can now be attacked in order to cancel them. This can be deterred with the anti-disruption upgrade disk.
  • RCDs for nukies and whatever don't have these downsides
  • The CE's roundstart RCD also doesn't have these downsides

Why It's Good For The Game

Construction and reconstruction are currently one of the worst aspects of SS13--they are so slow and tedious that any sort of mass destruction goes unfixed for 10-30+ minutes, if fixed at all. This limits us because it means people don't want traitors to create large explosions, for instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to print stock parts (or having stock parts removed), etc, in order to lessen this burden.

Changelog

🆑
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in order to cancel them. You can get the anti-disruption upgrade disk to prevent this.
balance: RCD construction/deconstruction is now slower if you already have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart RCD, nor any other RCDs such as combat RCDs.
/:cl:

@Mothblocks Mothblocks requested a review from Fikou August 15, 2023 07:07
@Mothblocks
Copy link
Member Author

@Fikou likes this

@tgstation-server tgstation-server added Balance Changes to functionality that modifies how effective certain methods are at powergaming Feature Exposes new bugs in interesting ways labels Aug 15, 2023
@Mothblocks Mothblocks removed the request for review from Fikou August 15, 2023 07:57
@iwishforducks
Copy link
Contributor

im torn on whether or not i like this. reconstruction is ass and RCDs make it so much easier. but as you have correctly assessed RCDs are quite powerful.

i dont know if i like making it so you have to install more upgrade disks into the RCD- the already existing upgrade disks were obtuse.

the ability to attack constructing RCD things is really good. honestly don’t even think there should be an upgrade disk to remove that part of it. it’d be really hard to tell if someone has that upgrade or not until you try to click their constructs. the nerf to construction speed if you’re building multiple at a time is confusing. i don’t really understand the point of that. is it to stop roundstart mass wall/window griefing? if so, wouldn’t the other engineers have tools to clean up said griefing? or is it to solve something else?

@Fikou
Copy link
Member

Fikou commented Aug 15, 2023

the ability to attack constructing RCD things is really good. honestly don’t even think there should be an upgrade disk to remove that part of it. it’d be really hard to tell if someone has that upgrade or not until you try to click their constructs

it makes their holograms red i ithnk

@iwishforducks
Copy link
Contributor

the ability to attack constructing RCD things is really good. honestly don’t even think there should be an upgrade disk to remove that part of it. it’d be really hard to tell if someone has that upgrade or not until you try to click their constructs

it makes their holograms red i ithnk

sounds good but also still kind of obtuse. i don’t know if many people would pick up on the difference. i personally think it should be consistent all around. overall not that big of a deal though, i think most would realize red = destructible. maybe.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

@improvedname
Copy link
Contributor

I thinj rcds lost alot of value and probaly will only be used to place walls/windows now since you dont no longer need to place rods down before you can place floortiles and now just floortile the hole uo

@necromanceranne
Copy link
Contributor

To think, these were once a theft objective stored in EVA

@SomeoneYouProbablyKnow
Copy link
Contributor

What abount engi-Borg RCDs? How are they gonna function?

@Jackal-boop
Copy link
Contributor

if goofball never finishes the RAT i guess this is a solution

@atlasle
Copy link
Contributor

atlasle commented Aug 15, 2023

if goofball never finishes the RAT i guess this is a solution

the rat is dumb and bloat they should just make that a mech thing

@MrMelbert
Copy link
Contributor

It's worth noting RCDs right now are in a really bad spot ever since the material value tweaks, since they use 20x as much material ammo now as they did in prior

image

@Mothblocks
Copy link
Member Author

Mothblocks commented Aug 15, 2023

It's worth noting RCDs right now are in a really bad spot ever since the material value tweaks, since they use 20x as much material ammo now as they did in prior

image

Gross, this should definitely change. RCDs should be only a little bit above manual material placing if that, with reconstruction being cheaper. What's the current exchange rate?

@Mothblocks
Copy link
Member Author

What abount engi-Borg RCDs? How are they gonna function?

I'm not sure, I can check later but since this is being test merged is there any chance you could check this before I do? :)

@Mothblocks
Copy link
Member Author

im torn on whether or not i like this. reconstruction is ass and RCDs make it so much easier. but as you have correctly assessed RCDs are quite powerful.

i dont know if i like making it so you have to install more upgrade disks into the RCD- the already existing upgrade disks were obtuse.

the ability to attack constructing RCD things is really good. honestly don’t even think there should be an upgrade disk to remove that part of it. it’d be really hard to tell if someone has that upgrade or not until you try to click their constructs. the nerf to construction speed if you’re building multiple at a time is confusing. i don’t really understand the point of that. is it to stop roundstart mass wall/window griefing? if so, wouldn’t the other engineers have tools to clean up said griefing? or is it to solve something else?

  • Uninterruptible effects are red (because the blue is going to be the most common and looks the best and red is the harshest counterpart)
  • The point of the slowdown changes is to hurt the roundstart RCD as a combat tool. I'm happy about RCD being usable in combat but I think the roundstart one specifically should only suggest that it can be used as one, not be an effective one. This change in particular is meant to make it harder to do something like walling off security, with this change if you were to try to place walls in front of the doors the warden should have enough time to run out and interrupt it and arrest you or whatever. As a note on your last part of this comment, I'm not a fan of problems being done by X job being primarily solved by that same job.
  • I'm completely fine overcorrecting on construction and adjusting back later

@Mothblocks
Copy link
Member Author

if goofball never finishes the RAT i guess this is a solution

I was against the RAT replacing the RCD to begin with so I would be happy with both tbh

@MrMelbert
Copy link
Contributor

Gross, this should definitely change. RCDs should be only a little bit above manual material placing if that, with reconstruction being cheaper. What's the current exchange rate?

In fairness it's only noticeable when constructing things which use a lot of materials, walls (and probably floors but I haven't checked) are unaffected. Top is the current rate.

@iwishforducks
Copy link
Contributor

iwishforducks commented Aug 15, 2023

alright so I went through and got some common costs for RCDs.

first and foremost, there is a max of 160 materials in an RCD. combat RCDs have 500.

1 iron sheet gives 4mu
1 glass sheet gives 4mu
1 reinforced glass sheet gives 6mu
1 plasteel sheet gives 12mu
1 matter cartridge gives 40mu

... matter cartridges take 6 iron and 4 glass to print, which means they are 100% efficient. there is no point in printing them.

going to list the matter unit cost for the item, then list the manual construction cost, and then the RCD material efficiency.

grille - 4mu - 1 iron sheet - 100% efficiency
directional normal window - 6mu - 1 glass sheet - 66% efficiency
directional reinforced window - 9mu - 1 reinforced glass sheet - 66% efficiency
fulltile normal window - 12mu - 2 glass sheets - 66% efficiency
fulltile reinforced window - 15mu - 2 reinforced glass sheets - 80% efficiency

wall - 16mu - 4 iron sheets - 100% efficiency

airlock - 16mu - 4 iron sheets - 100% efficiency
airlock (glass) - 20mu - 4 iron sheets 1 glass - 100% efficiency

machine - 25mu - 5 iron sheets - 80% efficiency
computer - 25mu - 5 iron sheets - 80% efficiency

reconstruction has a massive impact, cutting the cost of the item by a 1/8th. so if you make walls with an RCD on a reconstruction spot you are running at 800% efficiency.

for the most part, it seems like most items are efficient, barring windows for whatever reason. also building a wall on a wall girder cuts the cost of the girder. so it's still 100% efficient.

EDIT: fixed in #77650

@Jackal-boop
Copy link
Contributor

if goofball never finishes the RAT i guess this is a solution

the rat is dumb and bloat they should just make that a mech thing

i think you are silly

@saprasam
Copy link

engineers will finally fix 1 single broken tile into space that's depressurizing half of the station

Comment on lines +645 to +656
/obj/item/construction/rcd/ce
name = "professional RCD"
desc = "A higher-end model of the rapid construction device, prefitted with improved cooling and disruption prevention. Provided to the chief engineer."
upgrade = RCD_UPGRADE_ANTI_INTERRUPT | RCD_UPGRADE_NO_FREQUENT_USE_COOLDOWN
matter = 160
color = list(
0.3, 0.3, 0.7, 0.0,
1.0, 1.0, 0.2, 0.0,
-0.2, 0.0, 1.0, 0.0,
0.0, 0.0, 0.0, 1.0,
0.0, 0.0, 0.0, 0.0,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could turn this into a theft objective, since this will actually see use unlike the station blueprints

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate how unused the blueprints are because they are actually super useful and I use them all the time

@ExcessiveUseOfCobblestone
Copy link
Contributor

Bomb enjoyers 🤢

@Vincent983
Copy link
Contributor

hey, it means you can bomb MORE per antagonist round without the shuttle being called (the shuttle will still be called the moment a bomb with 1 devastation is detonated)

Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 1, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 1, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 2, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 2, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 3, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 3, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 3, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 3, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 3, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 3, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 5, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 5, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 5, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 5, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 7, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 7, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 8, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 8, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 9, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 9, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 12, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 12, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 12, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 12, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 13, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 13, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 15, 2024
…ompensate (tgstation#77641)

## About The Pull Request
- Gives engineers an RCD as part of their round start equipment
- RCD by default will build/deconstruct slower if you already have
another one in progress. This can be upgraded with the new cooling
upgrade disk. Reconstructing (anything that was there roundstart as per
the destructive scan) doesn't have this downside, only
construction/deconstruction.
- RCD construction effects can now be attacked in order to cancel them.
This can be deterred with the anti-disruption upgrade disk.
- RCDs for nukies and whatever don't have these downsides
- The CE's roundstart RCD also doesn't have these downsides

## Why It's Good For The Game
Construction and reconstruction are currently one of the worst aspects
of SS13--they are so slow and tedious that any sort of mass destruction
goes unfixed for 10-30+ minutes, if fixed at all. This limits us because
it means people don't want traitors to create large explosions, for
instance--I do and so I think it's crucial that we fix construction.

Reconstruction has already been improved on the RCD with the destructive
scans, but I see no reason to limit this to something so out of the way.

Ideally the RCD even gets more functionalities, like the ability to
print stock parts (or having stock parts removed), etc, in order to
lessen this burden.

## Changelog
:cl:
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in
order to cancel them. You can get the anti-disruption upgrade disk to
prevent this.
balance: RCD construction/deconstruction is now slower if you already
have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart
RCD, nor any other RCDs such as combat RCDs.
/:cl:

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Absolucy pushed a commit to Absolucy/Monkestation that referenced this pull request May 15, 2024
## About The Pull Request

tgstation#77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝 

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet