Clean up cmake/config #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move Imath.pc.in out of top directory to config subdir * Reformat and clarify comments * remove unused config settings that carried over from Iex/IlmThread Signed-off-by: Cary Phillips <cary@ilm.com>
waebbl
reviewed
Mar 10, 2021
CMakeLists.txt
Outdated
| # Tell CMake where to find the ImathConfig.cmake file. Makes it posible to call | ||
| # find_package(Imath) in downstream projects | ||
| # Tell CMake where to find the ImathConfig.cmake file. This makes it | ||
| # posible to call find_package(Imath) in downstream projects |
There was a problem hiding this comment.
Is it clear enough where the this points to? Logically I'd say, it's meaning is for the ImathConfig.cmake file, because that's the file used by downstream projects. But as a non-native English speaker, I got slightly confused whether it might belong to the line below the comment. Maybe for native speakers this is unambiguous and it's just due to lack of proper English skills.
There was a problem hiding this comment.
Thanks for that feedback. I rephrased it to be more clear, although if any cmake experts can clarify further, please do.
Signed-off-by: Cary Phillips <cary@ilm.com>
meshula
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cary Phillips cary@ilm.com