silence a few warnings noticed with -Weverything #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
lgritz
approved these changes
Jun 6, 2021
meshula
approved these changes
Jun 6, 2021
|
Oh crap, turns out I have software that depends on the symbol |
|
Don't worry, I can fix it on my end long before imath 3.1 is released. But it may yet turn out to plague others as well. |
|
I did wonder about that, but decided to go for the change anyway. It is an argument for pragma once instead of that mechanism, although I think people still worry about symlinks and such confusing the once mechanism? If that turns out to cause grief, let me know, we can revert that and add the disable-the-warning guards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kimball Thurston kdt3rd@gmail.com