Successor/predecessor functions use isnan() and isinf() #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isnan() and isinf() should more robust across different architectures than testing bit patterns. Also, the unions should use uint32_t/uint64_t since they're guaranteed to be the appropriate size. Signed-off-by: Cary Phillips <cary@ilm.com>
|
Maybe we should deprecate predf and succf, and change the implementations in the mean time to just call C++11 nextafter(). The only problem is that nextafter can throw, but I don't know if that will bother anybody, if anyone even actually uses succf/predf. |
|
I'm in favor of deprecation, with Cary's proposed re-implementation. |
Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
meshula
approved these changes
Sep 8, 2021
Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
meshula
approved these changes
Sep 11, 2021
|
I think all the i's have dotted and t's have crossed now? |
|
I think so, although I filed #211 to follow up on Larry's suggestion of just dispensing with succf/predf altogether. But this fix should suffice for now. |
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
Jan 17, 2022
…areFoundation#209) * Successor/predecessor functions use isnan() and isinf() isnan() and isinf() should more robust across different architectures than testing bit patterns. Also, the unions should use uint32_t/uint64_t since they're guaranteed to be the appropriate size. Signed-off-by: Cary Phillips <cary@ilm.com> * Add debugging info to testf()/testd() Signed-off-by: Cary Phillips <cary@ilm.com> * testf()/testd() checks isnan() Signed-off-by: Cary Phillips <cary@ilm.com> * Fix typo in testd() Signed-off-by: Cary Phillips <cary@ilm.com> * Cleanup & remove debugging info Signed-off-by: Cary Phillips <cary@ilm.com> * typo Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
that referenced
this pull request
Jan 20, 2022
* Successor/predecessor functions use isnan() and isinf() isnan() and isinf() should more robust across different architectures than testing bit patterns. Also, the unions should use uint32_t/uint64_t since they're guaranteed to be the appropriate size. Signed-off-by: Cary Phillips <cary@ilm.com> * Add debugging info to testf()/testd() Signed-off-by: Cary Phillips <cary@ilm.com> * testf()/testd() checks isnan() Signed-off-by: Cary Phillips <cary@ilm.com> * Fix typo in testd() Signed-off-by: Cary Phillips <cary@ilm.com> * Cleanup & remove debugging info Signed-off-by: Cary Phillips <cary@ilm.com> * typo Signed-off-by: Cary Phillips <cary@ilm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isnan() and isinf() should more robust across different architectures than testing bit patterns.
Also, the unions should use uint32_t/uint64_t since they're guaranteed to be the appropriate size.
Signed-off-by: Cary Phillips cary@ilm.com