Fix compiler warnings on windows #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fpsunflower
force-pushed
the
ck-fix-windows-warnings
branch
2 times, most recently
from
7410acb
to
a5a32b0
Compare
|
Ready for review. I should be able to get the CLA stuff sorted out next week. |
meshula
reviewed
Apr 11, 2022
meshula
reviewed
Apr 13, 2022
|
@fpsunflower I added you to the OpenEXR approved list of contributors under Epic's CCLA. Sorry for the delay! |
fpsunflower
force-pushed
the
ck-fix-windows-warnings
branch
from
a5a32b0
to
22bc38b
Compare
Thanks! Do I need to be added for the Imath repo separately? It looks like its still failing the automated check ... |
|
Nevermind @xlietz - the CLA seems to be working now! Thanks! |
Signed-off-by: Chris Kulla <ckulla@gmail.com>
fpsunflower
force-pushed
the
ck-fix-windows-warnings
branch
from
22bc38b
to
25983fa
Compare
cary-ilm
approved these changes
May 2, 2022
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
Jun 2, 2022
PR AcademySoftwareFoundation#250 changed the %lx to %llx to suppress an MSVC warning, but it introduced a gcc warning, where uint64_t is long, not long long. Better to leave it as %lx and just cast to long. It's only a printf anyway. Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
that referenced
this pull request
Oct 24, 2022
* Fix gcc compiler warning in testFun.cpp PR #250 changed the %lx to %llx to suppress an MSVC warning, but it introduced a gcc warning, where uint64_t is long, not long long. Better to leave it as %lx and just cast to long. It's only a printf anyway. Signed-off-by: Cary Phillips <cary@ilm.com> * cast to unsigned long long for %llx Signed-off-by: Cary Phillips <cary@ilm.com> * In printf, bit_cast to uint<n>_t and use PRIx<n> This shoudl properly avoid warnings on all platforms. Signed-off-by: Cary Phillips <cary@ilm.com> Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
pushed a commit
to cary-ilm/Imath
that referenced
this pull request
Oct 31, 2022
Signed-off-by: Chris Kulla <ckulla@gmail.com>
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
Oct 31, 2022
* Fix gcc compiler warning in testFun.cpp PR AcademySoftwareFoundation#250 changed the %lx to %llx to suppress an MSVC warning, but it introduced a gcc warning, where uint64_t is long, not long long. Better to leave it as %lx and just cast to long. It's only a printf anyway. Signed-off-by: Cary Phillips <cary@ilm.com> * cast to unsigned long long for %llx Signed-off-by: Cary Phillips <cary@ilm.com> * In printf, bit_cast to uint<n>_t and use PRIx<n> This shoudl properly avoid warnings on all platforms. Signed-off-by: Cary Phillips <cary@ilm.com> Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
pushed a commit
that referenced
this pull request
Nov 3, 2022
Signed-off-by: Chris Kulla <ckulla@gmail.com>
cary-ilm
added a commit
that referenced
this pull request
Nov 3, 2022
* Fix gcc compiler warning in testFun.cpp PR #250 changed the %lx to %llx to suppress an MSVC warning, but it introduced a gcc warning, where uint64_t is long, not long long. Better to leave it as %lx and just cast to long. It's only a printf anyway. Signed-off-by: Cary Phillips <cary@ilm.com> * cast to unsigned long long for %llx Signed-off-by: Cary Phillips <cary@ilm.com> * In printf, bit_cast to uint<n>_t and use PRIx<n> This shoudl properly avoid warnings on all platforms. Signed-off-by: Cary Phillips <cary@ilm.com> Signed-off-by: Cary Phillips <cary@ilm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC is fairly picking about casts that potentially loose precision. This made up the bulk of the warnings that occur out of the box on windows.
None of these are particularly serious and they almost all occur inside unit tests, but hopefully by fixing them it makes it more obvious if there are new warnings introduced in the future.