Support relative prefix in pkg-config #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake now exports CMAKE_INSTALL_LIBDIR/CMAKE_INSTALL_INCLUDEDIR instead of the *_FULL_* variables, and Imath.pc.in prepends the prefix explicitly, which makes it possible to support relative installation paths Signed-off-by: Cary Phillips <cary@ilm.com>
|
Thanks for getting to this, but this is not sufficient. It only addresses the relocability when CMAKE_INSTALL_LIBDIR/CMAKE_INSTALL_INCLUDEDIR are indeed relative, but for some platforms like NixOS they are actually absolute so this scheme doesn't work out there. Please see the provided links for a workaround that handles both cases. |
Signed-off-by: Cary Phillips <cary@ilm.com>
|
OK, I added the IS_ABSOLUTE logic you referenced, and this seems to now handle -DCMAKE_INSTALL_INCLUDEDIR=/path. But let me know if there's something this still doesn't address. |
|
That should be it, thanks! |
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Feb 5, 2023
During pkg-config generation, CMake now uses `CMAKE_INSTALL_LIBDIR`/`CMAKE_INSTALL_INCLUDEDIR` instead of the `_FULL_` variables, and does not prepend the prefix if they are absolute paths, which makes it possible to support relative installation paths. See AcademySoftwareFoundation/Imath#281 and AcademySoftwareFoundation/Imath#291 Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
to AcademySoftwareFoundation/openexr
that referenced
this pull request
Feb 7, 2023
…on (#1330) During pkg-config generation, CMake now uses `CMAKE_INSTALL_LIBDIR`/`CMAKE_INSTALL_INCLUDEDIR` instead of the `_FULL_` variables, and does not prepend the prefix if they are absolute paths, which makes it possible to support relative installation paths. See AcademySoftwareFoundation/Imath#281 and AcademySoftwareFoundation/Imath#291 Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
Feb 27, 2023
* Support relative prefix in pkg-config CMake now exports CMAKE_INSTALL_LIBDIR/CMAKE_INSTALL_INCLUDEDIR instead of the *_FULL_* variables, and Imath.pc.in prepends the prefix explicitly, which makes it possible to support relative installation paths Signed-off-by: Cary Phillips <cary@ilm.com> * Add CMake logic to handle relative vs absolute libdir/includedir Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
that referenced
this pull request
Feb 28, 2023
* Support relative prefix in pkg-config CMake now exports CMAKE_INSTALL_LIBDIR/CMAKE_INSTALL_INCLUDEDIR instead of the *_FULL_* variables, and Imath.pc.in prepends the prefix explicitly, which makes it possible to support relative installation paths Signed-off-by: Cary Phillips <cary@ilm.com> * Add CMake logic to handle relative vs absolute libdir/includedir Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
…on (AcademySoftwareFoundation#1330) During pkg-config generation, CMake now uses `CMAKE_INSTALL_LIBDIR`/`CMAKE_INSTALL_INCLUDEDIR` instead of the `_FULL_` variables, and does not prepend the prefix if they are absolute paths, which makes it possible to support relative installation paths. See AcademySoftwareFoundation/Imath#281 and AcademySoftwareFoundation/Imath#291 Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
to AcademySoftwareFoundation/openexr
that referenced
this pull request
Mar 5, 2023
…on (#1330) During pkg-config generation, CMake now uses `CMAKE_INSTALL_LIBDIR`/`CMAKE_INSTALL_INCLUDEDIR` instead of the `_FULL_` variables, and does not prepend the prefix if they are absolute paths, which makes it possible to support relative installation paths. See AcademySoftwareFoundation/Imath#281 and AcademySoftwareFoundation/Imath#291 Signed-off-by: Cary Phillips <cary@ilm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake now exports CMAKE_INSTALL_LIBDIR/CMAKE_INSTALL_INCLUDEDIR instead of the FULL variables, and Imath.pc.in prepends the prefix explicitly, which makes it possible to support relative installation paths
Signed-off-by: Cary Phillips cary@ilm.com