Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the subproject test #57

Merged

Conversation

kdt3rd
Copy link
Contributor

@kdt3rd kdt3rd commented Nov 7, 2020

If someone uses FetchContent then add_subdirectory, this correctly
disables the tests and clang format targets

Signed-off-by: Kimball Thurston kdt3rd@gmail.com

If someone uses FetchContent then add_subdirectory, this correctly
disables the tests and clang format targets

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice thing to do for upstream projects.

Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm
Copy link
Member

cary-ilm commented Dec 2, 2020

Closing and reopening, in the hopes that gets the CLA check unstuck....

@cary-ilm cary-ilm closed this Dec 2, 2020
@cary-ilm cary-ilm reopened this Dec 2, 2020
@cary-ilm cary-ilm merged commit 322aaa1 into AcademySoftwareFoundation:master Dec 2, 2020
@kdt3rd kdt3rd deleted the fix_subproject_test branch February 12, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants