Deprecate Math<T> in favor of std:: #65
Conversation
These were helpful to allow templated application of either double or float in the olden days, but in C++11 and beyond, std:: versions of these math functions do the same thing and should be preferred. For back compatibility for applications, I'm keeping Math<T> but defining them to just be the std:: versions. But the goal should be to remove them eventually. Signed-off-by: Larry Gritz <lg@larrygritz.com>
There was a problem hiding this comment.
This is great. I have a strong feeling we don't need to keep the Math::foo() functions; my argument as in lots of other threads is that separated Imath is new, why don't we move forward as much as possible at this point. If people really need the legacy functions, maybe we could instead provide ImathLegacy.h and stick a 2022 best before date in it, and not include it from any of our own code?
Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
I've augmented this PR to define |
config/ImathConfig.h.in
Outdated
| // | ||
| #if defined(__cplusplus) && (__cplusplus >= 201402L) | ||
| # define IMATH_DEPRECATED(msg) [[deprecated(msg)]] | ||
| #elif defined(_MSC_VER) |
There was a problem hiding this comment.
It's so nice to see that _MSC_VER doesn't have to be detected early to bypass the historically broken __cplusplus check!!
There was a problem hiding this comment.
Oh, well when you say it like that, I wonder if I've done it wrong. There are some compilers that don't like
#if defined(FOO) && ...expression involving FOO...
and I never quite remember when that's allowed. It's probably MSVC with the issue, right?
Perhaps I'll reorder this to be safe.
There was a problem hiding this comment.
It might depend on exactly which MSVC version it is. Hmmm. I'll fix to be sure it's 100% safe.
There was a problem hiding this comment.
Updated to be safer. Also caught one more file where things should have been changed to std::. Grep shows that's the last of it.
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
Microsoft being Microsoft, I'm sure the new ordering will be fine until the end of time. |
These were helpful to allow templated application of either double or
float in the olden days, but in C++11 and beyond, std:: versions of
these math functions do the same thing and should be preferred.
For back compatibility for applications, I'm keeping Math but
defining them to just be the std:: versions. But the goal should be
to remove them eventually.
Signed-off-by: Larry Gritz lg@larrygritz.com