Add MaterialX Graph Editor #1169
Conversation
|
|
This changelist implements a handful of minor simplifications to graph editor dependencies, removing the unused gl3w library and disabling installation steps for glfw.
There was a problem hiding this comment.
Hi @lfl-eholthouser,
This is really great work and kudas for figuring out all the graph traversal logic :).
I've left a bunch of small nitpicks to peruse as you see fit.
In general, one thing I found was it was really hard to read the Graph code since it contains logic for handling many different areas: property editor, ui nodes, placement, node creation.
My general suggestion is that it would be great to have this separated out a bit more.
A related suggestion / query is I think the model is that the "model" is embedded with the "view" and things occur on both at the same time (is this correct?)
So it seems some things done many times since the MaterialX Data model needs to be constantly revisited (e.g. input / output information extraction). So related to the first comment is perhaps making UiNode more than just a dumb wrapper but have logic inside and enough cached information to avoid possible repetitive calls. e.g. it seems there is enough information cached for pins to perform traversal but the MaterialX datamodel still needs to be accessed.
For @jstone-lucasfilm , a general question is should Material and parts of RenderView be consolidated with what in MaterialXView even if just for maintenance purposes as it seems a lot has been copied over.
Thanks for your patience with my comments :). Again it's all small stuff.
This changelist reorders the draw calls in the editor render loop, allowing a workaround in the framebuffer destructor to be removed. Additional minor improvements include the storage of screen dimensions as unsigned integers rather than floats, aligning them with the storage in the framebuffer classes.
This changelist updates getDefaultSearchPath in MaterialXGraphEditor to match the latest, simplified version in MaterialXView.
* Remove copy of ImGui 1.88 * Add submodule for ImGui 1.88 * Update CMake for submodule
* Remove code for ImGuiNodeEditor * Add submodule for ImGuiNodeEditor * Update CMake for submodule
* Remove code for ImGuiFileBrowser * Add submodule for ImGuiFileBrowser * Update CMake for submodule
This changelist fixes minor issues flagged by PVS-Studio in Graph.cpp, including: - Fix a duplicate null check in Graph::updateMaterials. - Fix a mismatched empty string test in Graph::propertyEditor. - Remove unused variables.
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
jstone-lucasfilm
changed the title
The MaterialX Graph Editor is an example application for visualizing, creating, and editing MaterialX graphs. It utilizes the ImGui framework as well as ImGui extensions such as the Node Editor and File Browser.
The MaterialX Graph Editor is an example application for visualizing, creating, and editing MaterialX graphs. It utilizes the ImGui framework as well as ImGui extensions such as the Node Editor and File Browser.