Add support for MaterialX builds on iOS #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morteeza
changed the title
Morteeza
force-pushed
the
MaterialX_iOS
branch
11 times, most recently
from
a5417f0
to
f4f7822
Compare
|
@Morteeza This proposal looks good to me, and let me know what your thoughts are on the error we're seeing in GitHub Actions. |
|
It's trying to build for iOS, but can we build for iOS in github CI? |
Morteeza
force-pushed
the
MaterialX_iOS
branch
13 times, most recently
from
931f174
to
1838af4
Compare
…e on iOS platform.
Morteeza
force-pushed
the
MaterialX_iOS
branch
from
1838af4
to
3d5ead6
Compare
|
Thanks @jstone-lucasfilm and @meshula . I believe this version should compile fine for both Mac and iOS. |
|
Ah nice, looking good! |
There was a problem hiding this comment.
This looks great to me, @Morteeza, and I had just one recommendation for maintaining the clarity of the top-level CMakeLists.txt file.
Morteeza
force-pushed
the
MaterialX_iOS
branch
from
f6dd1d3
to
aa86768
Compare
Morteeza
force-pushed
the
MaterialX_iOS
branch
from
f7595ab
to
9b68c51
Compare
jstone-lucasfilm
approved these changes
Aug 22, 2023
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit c5b376c
into
AcademySoftwareFoundation:main
14 checks passed
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
Thanks to @ikuznetcova for the contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @ikuznetcova for the contribution