Propagate uv scale and offset #1840
Conversation
Custom image nodes like ND_gltf_colorimage and ND_UsdUVTexture did not produce uv_scale and uv_offset inputs. Fix that by propagating the added inputs found inside a CompoundNode which represents a NodeGraph implementation of a NodeDef. Fixes AcademySoftwareFoundation#1716
| // points if that name can be related to the filename input. | ||
| // NOTE: This is enough to have UDIMs working with ND_gltf_colorimage | ||
| // and ND_UsdUVTexture, so we stop here at this time. | ||
| inputSocket = addInputSocket(name, nodeInput->getType()); |
There was a problem hiding this comment.
Hi @JGamache-autodesk,
I don't think this is enough and is inconsistent with how other sockets are "published" using <node name>_ <input name> . This would also resolve the issue that you should be able to support different UDIM scale/offsets for different image inputs -- i.e. there is no guarantee there is only one set of UDIM information.
There was a problem hiding this comment.
We should definitely split the issue, especially since this PR only attempts to fix single image wrappers like those found for glTf, USD, ADSK, Arnold, etc. Image nodes wrapped in simple NodeGraph implementations.
The second part where we support multi-image nodes with multiple UDIM scales should be indeed discussed and implemented correctly, but maybe should not be a showstopper for first fixing ND_UsdUVTexture and ND_gltf_colorimage.
|
@JGamache-autodesk We've now merged development work on MaterialX 1.39 back to the |
Exactly the same as AcademySoftwareFoundation#1840 but on the main branch.
|
Closing. Another pull request targeting main branch has been submitted. |
Fixes #1716
Propagate internally added ports when found inside a NodeGraph implementation of a NodeDef.
Testing:
build/bin/resources/Materials/TestSuite/stdlib/color_management/filename_cm_test/filename_CM_Test_ps.glslNG_tm_test()andNG_tm_retest()now have scale and offset parameters and that these parameters are passed to themx_image_color3()function.main()we use all scale and offset uniform parameters when calling either the NodeGraph functions or the regular image node.Filename_CM_Test_ps.zip