Adsk Contrib - Fix a bug with the Vc++ compilation flags. #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
michdolan
approved these changes
Jun 27, 2021
|
Friendly reminder that the pull request can now be merged. |
doug-walker
approved these changes
Jul 6, 2021
hodoulp
added a commit
that referenced
this pull request
Jul 6, 2021
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Hodoul Patrick.Hodoul@autodesk.com
The MSVC warning level was only enabled when the cmake flag warning as error was off and, the level 4 is inappropriate for existing projects as it contains lot of informational warnings. So, the code fixes the bug, set the warning level to 3 (which is the default one i.e. production quality level), and explains why level 4 is not used.
Note: The level 4 is recommended for new projects; otherwise, it could represent lot of work to fix all these warnings (even for OpenColorIO). Some warnings are related to method automatically inlined or not, structure packing, etc. Refer to the MSVC documentation for details about
/W4included warnings.