Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adsk Contrib - Fix a bug with the Vc++ compilation flags. #1419

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Adsk Contrib - Fix a bug with the Vc++ compilation flags. #1419

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6918583
Adsk Contrib - Fix a bug with the Vc++ compilation flags.
hodoulp Jun 21, 2021
dd7413b
Merge branch 'master' into adsk_contrib/fix_warning_bug
hodoulp Jul 5, 2021
8e20d07
Merge branch 'master' into adsk_contrib/fix_warning_bug
hodoulp Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions share/cmake/utils/CompilerFlags.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,12 @@ if(USE_MSVC)
)
endif()

# Explicitely specify the default warning level i.e. /W3.
# Note: Do not use /Wall (i.e. /W4) which adds 'informational' warnings.
set(PLATFORM_COMPILE_FLAGS "${PLATFORM_COMPILE_FLAGS} /W3")

if(OCIO_WARNING_AS_ERROR)
set(PLATFORM_COMPILE_FLAGS "${PLATFORM_COMPILE_FLAGS} /WX")
else()
set(PLATFORM_COMPILE_FLAGS "${PLATFORM_COMPILE_FLAGS} /Wall")
endif()

elseif(USE_CLANG)
Expand Down