DDS: honor ImageInput thread policy #3584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Github UI does not allow me to set this as "reviewed", so I'll just write 👍 🟢 here. |
|
GH only lets you designate somebody as a reviewer if they are an "org member", which I think means a designated committer with write perms. That's crazy, it comes up all the time that you might want a review by the person who reported a problem, or an expert in some area who is not a frequent contributor, etc. I understand why you don't want to allow any repo to request a review from any user at all -- it would be a way for people to spam well-known developers -- but I don't see why it wouldn't be simple to allow anyone who has previously interacted with the project to have their review requested or accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.