-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: write Windows build instructions #3602
Conversation
I recently wrote down how to build OIIO from source for myself (https://gist.github.com/aras-p/6497703c9b52f67761e6191343e43f7b), and maybe a slightly cleaned up version would be good to put into actual docs.
Thank you for that! |
Not sure if this is a bug in the project's CMake but you need to also specify |
Hmm, I don't have any Qt on my system, and just |
Taking what you wrote and what vcpkg have in their OIIO port I have managed to build OpenImageIO using:
Should also work if the triplet is |
From what I can see in
|
Now get the OIIO source and do one-time CMake configuration step. Replace `{*_ROOT}` below with folders where you have put the 3rd party | ||
dependencies. | ||
``` | ||
cd {OIIO_ROOT} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be more clear to call this OpenImageIO_ROOT, just to be consistent with the CMake convention that somebody would use so their downstream find_package(OpenImageIO) works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great, thanks so much, @aras-p. (I really need to get that phrase assigned permanently to a hotkey.)
I made one suggestion, which we don't have to fix in this PR, it's easy enough to patch afterwards. (The instructions here aren't wrong, I just think it may save us trouble down the road to match the other "how do you build downstream" instructions using the same nomenclature.)
I'm also thinking we should straighten out the USE_QT vs USE_QT5 confusion, but again, that sure doesn't need to be part of this PR, and maybe I need to think a bit about the least awkward way to handle that and also leave room for Qt6 eventually without that becoming yet another awkward transition.
I recently wrote down how to build OIIO from source for myself (https://gist.github.com/aras-p/6497703c9b52f67761e6191343e43f7b), and maybe a slightly cleaned up version would be good to put into actual docs.
I recently wrote down how to build OIIO from source for myself (https://gist.github.com/aras-p/6497703c9b52f67761e6191343e43f7b), and maybe a slightly cleaned up version would be good to put into actual docs.
Description
I recently wrote down how to build OIIO from source for myself (https://gist.github.com/aras-p/6497703c9b52f67761e6191343e43f7b), and maybe a slightly cleaned up version would be good to put into actual docs.
Tests
N/A
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).