Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved ordering of channels for EXR files. #904

Merged
merged 1 commit into from
Jul 9, 2014

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Jul 7, 2014

Now we very robustly cluster "layers" together (with the unnamed layer
first, if it exists), and within each layer have a canonical RGBAZ
order.

Now we very robustly cluster "layers" together (with the unnamed layer
first, if it exists), and within each layer have a canonical RGBAZ
order.
@lgritz
Copy link
Collaborator Author

lgritz commented Jul 9, 2014

Any feedback on this, @sebastianelsner ?

@lgritz lgritz merged commit e2942b0 into AcademySoftwareFoundation:master Jul 9, 2014
@lgritz lgritz deleted the lg-openexr branch July 9, 2014 18:31
@sebastianelsner
Copy link
Contributor

Both images submitted on the mailing list still make iv crash on windows.
Will test CentOS tomorrow at work.

@lgritz
Copy link
Collaborator Author

lgritz commented Jul 9, 2014

These changes just address the "channels in the wrong order" problem. I don't yet have any theory about why those files would crash.

If you do a 'oiiotool broken.exr -o out.exr', does that work? That is, can you coax OIIO core into reading and writing the file if iv (OpenGL, Qt, etc.) is not in the mix?

@sebastianelsner
Copy link
Contributor

using oiiotool the way you suggested works without crashing on win + linux. Also with your changes applied iv displays without crashing on CentOS, while it still does on Windows. I will try to investigate on Windows a bit more ans open a new ticket if necessary.

@sebastianelsner
Copy link
Contributor

After a bit more investigating I found that the crashes are still happening on both platforms under certain circumstances:
Open iv, open test.exr (files from mailing list post) > crash
Open iv, open test_small.exr > no crash > open test.exr > no crash

It seems if I load the small file first, the large file also loads. After that I can do the usual stuff like toggling images etc.

@sebastianelsner
Copy link
Contributor

@lgritz
Copy link
Collaborator Author

lgritz commented Aug 9, 2014

I still have been unable to reproduce on any platform.

Can you compile a debug version, run iv with -F (keeps in the foreground), run in the debugger such as gdb, and get a stack trace showing exactly where it's crashing?

@lgritz
Copy link
Collaborator Author

lgritz commented Aug 9, 2014

Oh, and if it's still a reproducible problem, let's open a new ticket on it.

@sebastianelsner
Copy link
Contributor

I will test and report in a different ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants