Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PySide6 removes QRegExp #1220

Closed
meshula opened this issue Feb 15, 2022 · 0 comments · Fixed by #1221
Closed

PySide6 removes QRegExp #1220

meshula opened this issue Feb 15, 2022 · 0 comments · Fixed by #1221
Labels
good first issue If you're looking for a way to contribute, but not sure where to start. This is a good first issue. help wanted We're looking for help from the community - you're weclome to volunteer! PySide6

Comments

@meshula
Copy link
Collaborator

meshula commented Feb 15, 2022

Problem: PySide6 removes QRegExp

  File "miniforge3/envs/otio-py310/lib/python3.10/site-packages/opentimelineview/details_widget.py", line 87, in highlightBlock
    expression = QtCore.QRegExp("(\\{|\\}|\\[|\\]|\\:|\\,)")
AttributeError: module 'PySide6.QtCore' has no attribute 'QRegExp'

QRegularExpression exists, but the regex syntax and class usage has changed substantially: https://doc.qt.io/qt-5/qregularexpression.html#notes-for-qregexp-users

It makes sense to port to the python standard re library, so that the code works in PySide2 and PySide6 without some sort of shim layer, or version selection code.

https://docs.python.org/3/library/re.html

Help welcome if anyone has time to look at this task.

See umbrella task: #1215

@meshula meshula added help wanted We're looking for help from the community - you're weclome to volunteer! good first issue If you're looking for a way to contribute, but not sure where to start. This is a good first issue. PySide6 labels Feb 15, 2022
@jminor jminor added this to the Public Beta 15 milestone May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue If you're looking for a way to contribute, but not sure where to start. This is a good first issue. help wanted We're looking for help from the community - you're weclome to volunteer! PySide6
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants