Rearrange the commandline files into a submodule. #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
- Coverage 91.34% 90.86% -0.48%
==========================================
Files 49 53 +4
Lines 4354 4489 +135
==========================================
+ Hits 3977 4079 +102
- Misses 377 410 +33
Continue to review full report at Codecov.
|
|
Yeah, I like it better now, since |
ssteinbach
force-pushed
the
rearranged_console_files
branch
from
c9ef7e4
to
e28ef28
Compare
ssteinbach
added a commit
to ssteinbach/OpenTimelineIO
that referenced
this pull request
Sep 17, 2018
…ndation#299) * Rearrange the commandline files into a submodule. * Add basic unit tests for console module.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the files from the
binsubdirectory and moves them intoconsolemodules inside the python packages. This lets thesetup.pybe cleaner in terms of generating the extensionless executable files, and also makes their functions (argument parser, etc) available for reuse by others.@alexwidener this rearranges some of the stuff you had done previously - what do you think?