Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null characters from Avid AAFs #474

Closed
thecargocultnz opened this issue Mar 28, 2019 · 5 comments
Closed

null characters from Avid AAFs #474

thecargocultnz opened this issue Mar 28, 2019 · 5 comments
Labels
bug A problem, flaw, or broken functionality.
Projects

Comments

@thecargocultnz
Copy link

Avid Media Composer AAFs are causing JSON strings with null characters (\u0000). This makes it tricky to parse for anyone downstream.
Is there some way to sanitise these while parsing?

For the record: this example was caused by using the "Time Compression Expansion" Audiosuite effect.

TCETest_MC1.aaf.zip

@ssteinbach ssteinbach added this to To do in AAF Adapter via automation Apr 1, 2019
@jminor jminor added this to the Public Beta 11 milestone Apr 3, 2019
@jminor
Copy link
Collaborator

jminor commented Apr 19, 2019

Specifically, if you read the provided AAF, you get this in the metadata:
"AvidASPIPlugInName": "Time Compression Expansion\u0000\u0000\uf37e\u1029"

@jminor jminor added the bug A problem, flaw, or broken functionality. label Apr 19, 2019
@jminor
Copy link
Collaborator

jminor commented Apr 19, 2019

This appears to be a bug in pyaaf2. @thecargocultnz would you like me to submit this bug to the upstream project?

@thecargocultnz
Copy link
Author

@jminor for ourselves we found a way to sanitise the data - but I'd say this would be worth fixing as it'll catch out a lot of people. So not urgent for us, but definitely a bug.

@jminor
Copy link
Collaborator

jminor commented Apr 23, 2019

I filed a pyaaf2 bug here: markreidvfx/pyaaf2#49

@jminor
Copy link
Collaborator

jminor commented Apr 26, 2019

This is fixed in pyaaf2 now: markreidvfx/pyaaf2@37de8c1

Next time there's a release of pyaaf2 we can update our dependency, but in the meantime you can pull the latest master of pyaaf2 to get this fix.

@jminor jminor closed this as completed Apr 26, 2019
AAF Adapter automation moved this from To do to Done Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem, flaw, or broken functionality.
Projects
AAF Adapter
  
Done
Development

No branches or pull requests

2 participants