Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers: AttributeError when calling __repr__ / __str__ #592

Closed
elabrosseRodeofx opened this issue Sep 27, 2019 · 3 comments
Closed

Markers: AttributeError when calling __repr__ / __str__ #592

elabrosseRodeofx opened this issue Sep 27, 2019 · 3 comments
Labels
bug A problem, flaw, or broken functionality.

Comments

@elabrosseRodeofx
Copy link
Contributor

The otio.schema.Marker object's __repr__ and __str__ methods are referencing a 'media_reference' and a 'source_range' attribute.
however Markers do not have those attributes. They do however have a 'marked_range' attribute that is not referenced in the __repr__ / __str__

Printing a Marker instance results in an AttributeError:

>>> otio.schema.Marker()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/devLocal/elabrosse/rdoenv/auto_lineup/otio/lib/python2.7/site-packages/opentimelineio/schema/marker.py", line 25, in __repr__
    repr(self.media_reference),
AttributeError: 'opentimelineio._otio.Marker' object has no attribute 'media_reference'

From what I see it seems that the content of opentimelineio/schema/clip.py was copy/pasted almost as is in opentimelineio/schema/marker.py.

My corporation is waiting for confirmation that our CLA was received. We will submit a PR as soon as possible.

@jminor
Copy link
Collaborator

jminor commented Sep 27, 2019

Yep, we got the CLA. Thanks for finding this oversight.

@elabrosseRodeofx
Copy link
Contributor Author

Made a PR:

#596

@reinecke
Copy link
Collaborator

I accidentally resolved this in #740 after it'd already been resolved in #596 (Oops!)

@reinecke reinecke added the bug A problem, flaw, or broken functionality. label Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem, flaw, or broken functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants