Extracted CMX3600 adapter and related sample data and tests #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
…O into extract_adapters
21 tasks
|
This looks pretty good to me. If you want to be really clean about this change we could separate the |
|
Yeah, I noticed the imortlib one made it's way in there after a rebase. |
Signed-off-by: apetrynet <flehnerheener@gmail.com>
apetrynet
commented
Nov 30, 2022
tests/baselines/plugin_module/otio_override_adapter/plugin_manifest.json
Outdated
Show resolved
Hide resolved
|
What do we do about references to the cmx adapter in the documentation? Should we do that in this PR or do a proper doc overhaul when we're done with all the adapters? |
|
Lets do the documentation change after we have the adapters split out, but before landing the extract_adapters branch into main. |
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
|
|
…ed in a separate PR. Will rebase when merged Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
… in tests Signed-off-by: apetrynet <flehnerheener@gmail.com>
…SoftwareFoundation#1488) * add "extract_adapters" to CI triggers * use "otiod" as override example Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
… in tests Signed-off-by: apetrynet <flehnerheener@gmail.com>
…extracted Signed-off-by: apetrynet <flehnerheener@gmail.com>
…dapters # Conflicts: # tests/test_examples.py
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## extract_adapters #1487 +/- ##
====================================================
- Coverage 80.09% 79.35% -0.74%
====================================================
Files 198 193 -5
Lines 21703 20617 -1086
Branches 4298 4152 -146
====================================================
- Hits 17382 16361 -1021
+ Misses 2174 2145 -29
+ Partials 2147 2111 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jminor
approved these changes
Dec 5, 2022
rosborne132
pushed a commit
to rosborne132/OpenTimelineIO
that referenced
this pull request
Jan 19, 2023
…oftwareFoundation#1487) * Removed the cmx_3600 adapter * Removed sample data only used by the cmx_3600 adapter * Add "extract_adapters" to CI triggers * otioz test called for an edl we removed. Replaced with an otio file * Converted screening_example.edl to screening_example.otio and used it in tests * Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted * Autogenerated docs for CMX3600 removed Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Robert Osborne <ozborne132@gmail.com>
reinecke
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Removed the cmx_3600 adapter * Removed sample data only used by the cmx_3600 adapter * Add "extract_adapters" to CI triggers * otioz test called for an edl we removed. Replaced with an otio file * Converted screening_example.edl to screening_example.otio and used it in tests * Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted * Autogenerated docs for CMX3600 removed Signed-off-by: apetrynet <flehnerheener@gmail.com>
reinecke
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Removed the cmx_3600 adapter * Removed sample data only used by the cmx_3600 adapter * Add "extract_adapters" to CI triggers * otioz test called for an edl we removed. Replaced with an otio file * Converted screening_example.edl to screening_example.otio and used it in tests * Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted * Autogenerated docs for CMX3600 removed Signed-off-by: apetrynet <flehnerheener@gmail.com>
reinecke
pushed a commit
that referenced
this pull request
Apr 4, 2024
* Removed the cmx_3600 adapter * Removed sample data only used by the cmx_3600 adapter * Add "extract_adapters" to CI triggers * otioz test called for an edl we removed. Replaced with an otio file * Converted screening_example.edl to screening_example.otio and used it in tests * Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted * Autogenerated docs for CMX3600 removed Signed-off-by: apetrynet <flehnerheener@gmail.com>
reinecke
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Removed the cmx_3600 adapter * Removed sample data only used by the cmx_3600 adapter * Add "extract_adapters" to CI triggers * otioz test called for an edl we removed. Replaced with an otio file * Converted screening_example.edl to screening_example.otio and used it in tests * Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted * Autogenerated docs for CMX3600 removed Signed-off-by: apetrynet <flehnerheener@gmail.com>
reinecke
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Removed the cmx_3600 adapter * Removed sample data only used by the cmx_3600 adapter * Add "extract_adapters" to CI triggers * otioz test called for an edl we removed. Replaced with an otio file * Converted screening_example.edl to screening_example.otio and used it in tests * Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted * Autogenerated docs for CMX3600 removed Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
This PR is related to issue #1386
Summarize your change.
This PR removes the
cmx_3600adapter and related sample files and tests.There might still be some bits and pieces left, like in the documentation.