Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fcp adapter #1501

Conversation

apetrynet
Copy link
Contributor

Part of the ongoing effort to move adapters to their own repositories. #1386
Removed fcp xml adapter and related tests.
Auto documentation on adapters is updated.

Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
…ed in a separate PR. Will rebase when merged

Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
… in tests

Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
… in tests

Signed-off-by: apetrynet <flehnerheener@gmail.com>
…extracted

Signed-off-by: apetrynet <flehnerheener@gmail.com>
…dapters

# Conflicts:
#	tests/test_examples.py
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
…ole tests.

Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
…ole tests.

Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: apetrynet <flehnerheener@gmail.com>
@apetrynet apetrynet changed the base branch from main to extract_adapters December 14, 2022 23:23
Signed-off-by: apetrynet <flehnerheener@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Merging #1501 (012cbc7) into extract_adapters (7a0a8c7) will decrease coverage by 0.95%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           extract_adapters    #1501      +/-   ##
====================================================
- Coverage             78.24%   77.28%   -0.96%     
====================================================
  Files                   190      188       -2     
  Lines                 18816    17644    -1172     
  Branches               3846     3679     -167     
====================================================
- Hits                  14722    13636    -1086     
+ Misses                 2031     1980      -51     
+ Partials               2063     2028      -35     
Flag Coverage Δ
py-unittests 77.28% <100.00%> (-0.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_console.py 95.33% <100.00%> (ø)
src/opentimelineio/timeline.h 69.23% <0.00%> (-23.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a0a8c7...012cbc7. Read the comment docs.

Signed-off-by: apetrynet <flehnerheener@gmail.com>
@apetrynet apetrynet merged commit 04e6ab2 into AcademySoftwareFoundation:extract_adapters Dec 15, 2022
rosborne132 pushed a commit to rosborne132/OpenTimelineIO that referenced this pull request Jan 19, 2023
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: rosborne132 <ozborne132@gmail.com>
Signed-off-by: Robert Osborne <ozborne132@gmail.com>
reinecke pushed a commit that referenced this pull request Oct 6, 2023
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <flehnerheener@gmail.com>
reinecke pushed a commit that referenced this pull request Oct 6, 2023
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <flehnerheener@gmail.com>
reinecke pushed a commit that referenced this pull request Apr 4, 2024
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <flehnerheener@gmail.com>
reinecke pushed a commit that referenced this pull request Apr 12, 2024
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <flehnerheener@gmail.com>
reinecke pushed a commit that referenced this pull request Apr 12, 2024
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <flehnerheener@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants