Replaced usages of deprecated pkg_resources module #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tlib module Signed-off-by: Eric Reinecke <ereinecke@netflix.com>
reinecke
force-pushed
the
remove-pkg-resources
branch
from
c47710b
to
b680372
Compare
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
reinecke
force-pushed
the
remove-pkg-resources
branch
from
9e30021
to
c78df0c
Compare
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1675 +/- ##
==========================================
+ Coverage 79.83% 79.86% +0.02%
==========================================
Files 197 197
Lines 21769 21764 -5
Branches 4355 4353 -2
==========================================
+ Hits 17379 17381 +2
+ Misses 2236 2230 -6
+ Partials 2154 2153 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
pkg_resourcesis now deprecated. This PR removes references to that module.Refactored
plugin.manifestmodule to factor the pip installed package discovery into a separate function. Madeotiopluginfoandotioconvertuse that function rather than doing their own plugin discovery.Reference associated tests.
I did not add new tests, but I validated the output of
otiopluginfo --versionandotioconvert --versionto validate they're nearly identical. The only difference is that the stringPlugins from pkg_resources:is nowPlugins from installed packages:.