Ensure tests have assert when building in a release mode

Fixes warnings and makes sure tests are ... testing Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
AcademySoftwareFoundation · Jul 23, 2019 · fe93c2c · fe93c2c
1 parent a5fbf7d
commit fe93c2c
Show file tree

Hide file tree

Showing 101 changed files with 348 additions and 38 deletions.
diff --git a/IlmBase/HalfTest/main.cpp b/IlmBase/HalfTest/main.cpp
@@ -3,6 +3,10 @@
 // Copyright Contributors to the OpenEXR Project.
 //
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
+
 #include <testSize.h>
 #include <testArithmetic.h>
 #include <testError.h>

diff --git a/IlmBase/HalfTest/testArithmetic.cpp b/IlmBase/HalfTest/testArithmetic.cpp
@@ -3,6 +3,10 @@
 // Copyright Contributors to the OpenEXR Project.
 //
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
+
 #include <testArithmetic.h>
 #include "half.h"
 #include <iostream>

diff --git a/IlmBase/HalfTest/testBitPatterns.cpp b/IlmBase/HalfTest/testBitPatterns.cpp
@@ -3,6 +3,10 @@
 // Copyright Contributors to the OpenEXR Project.
 //
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
+
 #include <testBitPatterns.h>
 #include "half.h"
 #include <float.h>

diff --git a/IlmBase/HalfTest/testClassification.cpp b/IlmBase/HalfTest/testClassification.cpp
@@ -3,6 +3,10 @@
 // Copyright Contributors to the OpenEXR Project.
 //
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
+
 #include <testClassification.h>
 #include "half.h"
 #include <iostream>

diff --git a/IlmBase/HalfTest/testError.cpp b/IlmBase/HalfTest/testError.cpp
@@ -3,6 +3,10 @@
 // Copyright Contributors to the OpenEXR Project.
 //
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
+
 #include <testError.h>
 #include "half.h"
 #include <iostream>

diff --git a/IlmBase/HalfTest/testFunction.cpp b/IlmBase/HalfTest/testFunction.cpp
@@ -3,6 +3,10 @@
 // Copyright Contributors to the OpenEXR Project.
 //
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
+
 #include <testFunction.h>
 #include "halfFunction.h"
 #include <iostream>

diff --git a/IlmBase/HalfTest/testLimits.cpp b/IlmBase/HalfTest/testLimits.cpp
@@ -3,6 +3,10 @@
 // Copyright Contributors to the OpenEXR Project.
 //
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
+
 #include <testLimits.h>
 #include "halfLimits.h"
 #include <iostream>

diff --git a/IlmBase/HalfTest/testSize.cpp b/IlmBase/HalfTest/testSize.cpp
@@ -3,6 +3,10 @@
 // Copyright Contributors to the OpenEXR Project.
 //
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
+
 #include <testSize.h>
 #include "half.h"
 #include <iostream>

diff --git a/IlmBase/IexTest/main.cpp b/IlmBase/IexTest/main.cpp
@@ -32,7 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
-
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testBaseExc.h>
 

diff --git a/IlmBase/IexTest/testBaseExc.cpp b/IlmBase/IexTest/testBaseExc.cpp
@@ -32,7 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
-
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testBaseExc.h>
 #include <Iex.h>

diff --git a/IlmBase/IlmThread/IlmThreadSemaphorePosix.cpp b/IlmBase/IlmThread/IlmThreadSemaphorePosix.cpp
@@ -60,8 +60,12 @@ Semaphore::Semaphore (unsigned int value)
 
 Semaphore::~Semaphore ()
 {
+#ifdef NDEBUG
+    ::sem_destroy (&_semaphore);
+#else
     int error = ::sem_destroy (&_semaphore);
     assert (error == 0);
+#endif
 }
 
 

diff --git a/IlmBase/ImathTest/main.cpp b/IlmBase/ImathTest/main.cpp
@@ -32,7 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
-
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testVec.h>
 #include <testRoots.h>

diff --git a/IlmBase/ImathTest/testBox.cpp b/IlmBase/ImathTest/testBox.cpp
@@ -32,6 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testBoxAlgo.h>
 #include "ImathBoxAlgo.h"

diff --git a/IlmBase/ImathTest/testBoxAlgo.cpp b/IlmBase/ImathTest/testBoxAlgo.cpp
@@ -32,6 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testBoxAlgo.h>
 #include "ImathBoxAlgo.h"

diff --git a/IlmBase/ImathTest/testColor.cpp b/IlmBase/ImathTest/testColor.cpp
@@ -32,7 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
-
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testColor.h>
 #include "ImathColor.h"

diff --git a/IlmBase/ImathTest/testExtractEuler.cpp b/IlmBase/ImathTest/testExtractEuler.cpp
@@ -32,6 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testExtractEuler.h>
 #include "ImathMatrixAlgo.h"

diff --git a/IlmBase/ImathTest/testExtractSHRT.cpp b/IlmBase/ImathTest/testExtractSHRT.cpp
@@ -32,6 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testExtractSHRT.h>
 #include "ImathMatrixAlgo.h"
@@ -443,4 +446,3 @@ testExtractSHRT ()
 	cerr << "  Caught exception: " << e.what () << endl;
     }
 }
-
diff --git a/IlmBase/ImathTest/testFrustum.cpp b/IlmBase/ImathTest/testFrustum.cpp
@@ -32,7 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
-
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testFrustum.h>
 #include "ImathFrustum.h"

diff --git a/IlmBase/ImathTest/testFrustumTest.cpp b/IlmBase/ImathTest/testFrustumTest.cpp
@@ -32,7 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
-
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testFrustumTest.h>
 #include "ImathFrustum.h"

diff --git a/IlmBase/ImathTest/testFun.cpp b/IlmBase/ImathTest/testFun.cpp
@@ -32,6 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testFun.h>
 #include "ImathFun.h"

diff --git a/IlmBase/ImathTest/testInvert.cpp b/IlmBase/ImathTest/testInvert.cpp
@@ -32,7 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
-
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testInvert.h>
 #include "ImathMatrix.h"

diff --git a/IlmBase/ImathTest/testJacobiEigenSolver.cpp b/IlmBase/ImathTest/testJacobiEigenSolver.cpp
@@ -32,6 +32,10 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
+
 #include "ImathMatrix.h"
 #include "ImathMatrixAlgo.h"
 #include <iostream>
@@ -309,5 +313,3 @@ testJacobiEigenSolver()
 
     cout << "************      ALL PASS          ************" << endl;
 }
-
-
diff --git a/IlmBase/ImathTest/testLineAlgo.cpp b/IlmBase/ImathTest/testLineAlgo.cpp
@@ -32,6 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testLineAlgo.h>
 #include "ImathLineAlgo.h"

diff --git a/IlmBase/ImathTest/testMatrix.cpp b/IlmBase/ImathTest/testMatrix.cpp
@@ -32,7 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
-
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testMatrix.h>
 #include "ImathMatrix.h"

diff --git a/IlmBase/ImathTest/testMiscMatrixAlgo.cpp b/IlmBase/ImathTest/testMiscMatrixAlgo.cpp
@@ -32,6 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testMiscMatrixAlgo.h>
 #include "ImathMatrixAlgo.h"
@@ -337,5 +340,3 @@ testMiscMatrixAlgo ()
         cerr << "  Caught exception: " << e.what () << endl;
     }
 }
-
-
diff --git a/IlmBase/ImathTest/testProcrustes.cpp b/IlmBase/ImathTest/testProcrustes.cpp
@@ -32,6 +32,10 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
+
 #include "ImathMatrixAlgo.h"
 #include "ImathRandom.h"
 #include "ImathEuler.h"
@@ -398,5 +402,3 @@ testProcrustes ()
     std::cout << "Testing Procrustes algorithms in double precision..." << std::endl;
     testProcrustesImp<double>();
 }
-
-
diff --git a/IlmBase/ImathTest/testQuat.cpp b/IlmBase/ImathTest/testQuat.cpp
@@ -32,6 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testQuat.h>
 #include "ImathQuat.h"

diff --git a/IlmBase/ImathTest/testQuatSetRotation.cpp b/IlmBase/ImathTest/testQuatSetRotation.cpp
@@ -32,6 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testQuatSetRotation.h>
 #include "ImathQuat.h"

diff --git a/IlmBase/ImathTest/testQuatSlerp.cpp b/IlmBase/ImathTest/testQuatSlerp.cpp
@@ -32,6 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testQuatSlerp.h>
 #include "ImathQuat.h"
@@ -197,4 +200,3 @@ testQuatSlerp ()
 
     cout << "ok\n" << endl;
 }
-
diff --git a/IlmBase/ImathTest/testRandom.cpp b/IlmBase/ImathTest/testRandom.cpp
@@ -32,7 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
-
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testRandom.h>
 #include "ImathRandom.h"

diff --git a/IlmBase/ImathTest/testRoots.cpp b/IlmBase/ImathTest/testRoots.cpp
@@ -32,7 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
-
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testRoots.h>
 #include "ImathRoots.h"
@@ -256,5 +258,3 @@ testRoots ()
     solve (3,  -6,  30,   0,   0,   0); // real solutions: none
     cout << "ok\n" << endl;
 }
-
-
diff --git a/IlmBase/ImathTest/testShear.cpp b/IlmBase/ImathTest/testShear.cpp
@@ -32,7 +32,9 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
-
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
 
 #include <testShear.h>
 #include "ImathShear.h"

diff --git a/IlmBase/ImathTest/testTinySVD.cpp b/IlmBase/ImathTest/testTinySVD.cpp
@@ -32,6 +32,10 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
+#ifdef NDEBUG
+#    undef NDEBUG
+#endif
+
 #include "ImathMatrixAlgo.h"
 #include <iostream>
 #include <assert.h>
@@ -357,4 +361,3 @@ testTinySVD ()
     std::cout << "Testing TinySVD algorithms in double precision..." << std::endl;
     testTinySVDImp<double>();
 }
-