Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows min/max build test failure #1215

Closed
Arbeyem opened this issue Dec 15, 2021 · 2 comments · Fixed by #1239
Closed

Windows min/max build test failure #1215

Arbeyem opened this issue Dec 15, 2021 · 2 comments · Fixed by #1239
Labels
Bug A bug in the source code Windows

Comments

@Arbeyem
Copy link

Arbeyem commented Dec 15, 2021

Using openexr v3.1.3.
'src/test/openexrcoretest/compression.cpp' throws multiple min/max is not a member of 'std' errors when compiling.

What I tried:
Ensured NOMINMAX was properly defined, no change. Including <algorithm> in the file resolved the issue.

What happened:
Build fails when the CMake option 'BUILD_TESTING' is set to 'ON' (default) on Windows using MSVC14.

What you expected to happen instead:
Test compiles successfully.

@meshula meshula added Bug A bug in the source code Windows labels Dec 16, 2021
@meshula
Copy link
Contributor

meshula commented Dec 16, 2021

Thanks for the report. Please feel free to submit a PR, or we can take care of it.

@cary-ilm
Copy link
Member

Apologies for missing this. PR #1238 adds . Presumably this is peculiar to MSVC14, since it works with 16 and 17 in our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in the source code Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants