Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openexr 2.3.0 static cmake build broken. #333

Closed
LazyDodo opened this issue Aug 13, 2018 · 2 comments
Closed

openexr 2.3.0 static cmake build broken. #333

LazyDodo opened this issue Aug 13, 2018 · 2 comments
Labels
Needs Discussion To be discussed in the technical steering committee

Comments

@LazyDodo
Copy link

Building openexr 2.3.0 on windows , vs2015.5 , cmake 3.11.2 and with -DOPENEXR_BUILD_STATIC=ON

initially it was unhappy about the set_target_properties in IlmImfUtil/CMakeLists.txt

  CMake Error at IlmImfUtil/CMakeLists.txt:59 (SET_TARGET_PROPERTIES):
    SET_TARGET_PROPERTIES called with incorrect number of arguments.

took a quick peek, decided I'd be ok without it and took out that part out and hit
the more troublesome part.

  CMake Error at IlmImfUtil/CMakeLists.txt:89 (add_library):
    add_library cannot create ALIAS target "OpenEXR::IlmImfUtil_static" because
    target "IlmImfUtil_static" does not already exist.

and it's doesn't appear to be wrong, there is a branch for OPENEXR_BUILD_SHARED in IlmImfUtil/CMakeLists.txt to create the IlmImfUtil target but nothing to create the IlmImfUtil_static target.

@LazyDodo
Copy link
Author

Seems like it's just the release tar.gz that is having a real bad time there, grabbing the latest from git seems to be a lot happier.

@cary-ilm cary-ilm added the CMake label Jun 13, 2019
@cary-ilm cary-ilm added the Needs Discussion To be discussed in the technical steering committee label Jun 26, 2019
@kdt3rd kdt3rd mentioned this issue Jul 11, 2019
@kdt3rd
Copy link
Contributor

kdt3rd commented Jul 17, 2019

A complete refactor of the cmake has taken place, modernizing cmake to match the "Modern CMake" guidelines and practices, we no longer have entirely custom BUILD_SHARED variables (just use the normal cmake BUILD_SHARED_LIBS), and had a major snafu in the last release with tarballs, so this should be fixed in the next release we make (if you want to test the master branch, and report any issues separately, that would be awesome). Thanks for the report!

@kdt3rd kdt3rd closed this as completed Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion To be discussed in the technical steering committee
Projects
None yet
Development

No branches or pull requests

3 participants