Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IlmImf CMake dependency issue #342

Closed
smaragden opened this issue Sep 26, 2018 · 0 comments
Closed

IlmImf CMake dependency issue #342

smaragden opened this issue Sep 26, 2018 · 0 comments
Labels
Bug A bug in the source code Needs Discussion To be discussed in the technical steering committee

Comments

@smaragden
Copy link

It looks like there's a copy & paste bug in the CMakeLists.txt file in IlmImf.
the dwaLookups and b44ExpLogTable dependencies are switched for static builds.

here's a patch:

diff --git a/OpenEXR/IlmImf/CMakeLists.txt b/OpenEXR/IlmImf/CMakeLists.txt
index e1a8740..e36c1cd 100644
--- a/OpenEXR/IlmImf/CMakeLists.txt
+++ b/OpenEXR/IlmImf/CMakeLists.txt
@@ -243,11 +243,11 @@ IF (OPENEXR_BUILD_STATIC)
   ENDIF ()
 
   iF (BUILD_DWALOOKUPS)
-    ADD_DEPENDENCIES ( IlmImf_static b44ExpLogTable )
+    ADD_DEPENDENCIES ( IlmImf_static dwaLookups )
   ENDIF ()
 
   IF (BUILD_B44EXPLOGTABLE)
-    ADD_DEPENDENCIES ( IlmImf_static dwaLookups )
+    ADD_DEPENDENCIES ( IlmImf_static b44ExpLogTable )
   ENDIF()
 
 ENDIF ()

/Fredrik
@cary-ilm cary-ilm added the CMake label Jun 13, 2019
@cary-ilm cary-ilm added Bug A bug in the source code Needs Discussion To be discussed in the technical steering committee labels Jun 26, 2019
kdt3rd added a commit to kdt3rd/openexr that referenced this issue Jun 27, 2019
@kdt3rd
Fix AcademySoftwareFoundation#342, copy paste bug with dependencies
32c79a9 
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
@kdt3rd kdt3rd self-assigned this Jun 27, 2019
@kdt3rd kdt3rd closed this as completed in 2b28d90 Jun 28, 2019
DominicJacksonBFX pushed a commit to boris-fx/mocha-openexr that referenced this issue Jun 22, 2022
@kdt3rd @DominicJacksonBFX
Fix AcademySoftwareFoundation#342, copy paste bug with dependencies
605283a 
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in the source code Needs Discussion To be discussed in the technical steering committee
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kdt3rd @smaragden @cary-ilm